<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>The error messages or the warnings are not related to r253681. They seem to be purely asan/tsan test failures.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'>-Betul<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span style='font-size:11.0pt;font-family:"Calibri",sans-serif'> Daniel Sanders [mailto:Daniel.Sanders@imgtec.com] <br><b>Sent:</b> Sunday, November 22, 2015 8:58 AM<br><b>To:</b> Xinliang David Li<br><b>Cc:</b> Betul Buyukkurt; llvm-commits@lists.llvm.org<br><b>Subject:</b> RE: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>Just to let you know: As of r253681 the failure changed. It gets past the compilation failure now but I can't tell if the current failure is related to your change or something else that happened in the few days the build was red.<br><br>See </span><a href="http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6638" target="_blank"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6638</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'> for the log that tested that commit.<o:p></o:p></span></p><div><div class=MsoNormal align=center style='text-align:center'><span style='color:black'><hr size=2 width="100%" align=center></span></div><div id=divRpF180668><p class=MsoNormal style='margin-bottom:12.0pt'><b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'> Xinliang David Li [xinliangli@gmail.com]<br><b>Sent:</b> 20 November 2015 19:21<br><b>To:</b> Daniel Sanders<br><b>Cc:</b> Betul Buyukkurt; </span><a href="mailto:llvm-commits@lists.llvm.org"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>llvm-commits@lists.llvm.org</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'><br><b>Subject:</b> Re: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.</span><span style='color:black'><o:p></o:p></span></p></div><div><div><p class=MsoNormal><span style='color:black'>I happen to have a pending clean up patch that should fix the problem. Patch coming soon .. <o:p></o:p></span></p><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal><span style='color:black'>David<o:p></o:p></span></p></div><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div></div><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p><div><p class=MsoNormal><span style='color:black'>On Fri, Nov 20, 2015 at 11:16 AM, Xinliang David Li <</span><a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a><span style='color:black'>> wrote:<o:p></o:p></span></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'><div><p class=MsoNormal><span style='color:black'>Let me take a look.</span><span class=hoenzb><span style='color:#888888'> </span><span style='color:#888888'><o:p></o:p></span></span></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal><span style='color:#888888'>David<o:p></o:p></span></p></div></div><div><div><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p><div><p class=MsoNormal><span style='color:black'>On Fri, Nov 20, 2015 at 11:05 AM, Daniel Sanders <</span><a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a><span style='color:black'>> wrote:<o:p></o:p></span></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'><div><div><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>r253687 has done the trick. Thanks.<br><br>I think that just leaves sanitizer_x86_64-freebsd which is failing (</span><a href="http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6637/steps/compile/logs/stdio" target="_blank"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6637/steps/compile/logs/stdio</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>) with errors of the form: <o:p></o:p></span></p><pre><span style='color:black'>In file included from /usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfilingBuffer.c:10:<o:p></o:p></span></pre><pre><span style='color:black'>/usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfiling.h:58:9: error: unknown type name 'uint8_t'<o:p></o:p></span></pre><pre><span style='color:black'> const uint8_t *FunctionPointer;<o:p></o:p></span></pre><pre><span style='color:black'>In file included from /usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfilingFile.c:10:<o:p></o:p></span></pre><pre><span style='color:black'>/usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfiling.h:58:9: error: unknown type name 'uint8_t'<o:p></o:p></span></pre><pre><span style='color:black'> ^<o:p></o:p></span></pre><pre><span style='color:black'> const uint8_t *FunctionPointer;<o:p></o:p></span></pre><pre><span style='color:black'> ^<br><br>I'm not sure who can help you with this one.<o:p></o:p></span></pre><div><div class=MsoNormal align=center style='text-align:center'><span style='color:black'><hr size=2 width="100%" align=center></span></div><div><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'> Daniel Sanders<br><b>Sent:</b> 20 November 2015 18:47<br><b>To:</b> Xinliang David Li; Betul Buyukkurt; </span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>llvm-commits@lists.llvm.org</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'> <o:p></o:p></span></p><div><div><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'><br><b>Subject:</b> RE: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<o:p></o:p></span></p></div></div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div><div><div><div><div><p class=MsoNormal><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>Sure, I see you've committed it and I'd test it on the same machine as that builder so I'll keep an eye on that build for now.<o:p></o:p></span></p><div><div class=MsoNormal align=center style='text-align:center'><span style='color:black'><hr size=2 width="100%" align=center></span></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'> Xinliang David Li [</span><a href="mailto:xinliangli@gmail.com" target="_blank"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>xinliangli@gmail.com</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:black'>]<br><b>Sent:</b> 20 November 2015 17:42<br><b>To:</b> Betul Buyukkurt; Daniel Sanders<br><b>Subject:</b> Re: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.</span><span style='color:black'><o:p></o:p></span></p></div><div><div><p class=MsoNormal><span style='color:black'>Daniel, can you help test the following small patch? <o:p></o:p></span></p><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal><span style='color:black'>thanks,<o:p></o:p></span></p></div><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal><span style='color:black'>David<o:p></o:p></span></p></div></div><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p><div><p class=MsoNormal><span style='color:black'>On Fri, Nov 20, 2015 at 9:36 AM, Xinliang David Li <</span><a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a><span style='color:black'>> wrote:<o:p></o:p></span></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'><div><p class=MsoNormal><span style='color:black'>Or disable value profiling for those targets -- such as stub out the __llvm_profile_instrument_target.. <o:p></o:p></span></p><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div><div><p class=MsoNormal><span style='color:black'>I can help with a patch for Daniel to test.<o:p></o:p></span></p></div><div><p class=MsoNormal><span style='color:#888888'><o:p> </o:p></span></p></div><div><div><p class=MsoNormal><span style='color:#888888'><o:p> </o:p></span></p></div><div><p class=MsoNormal><span style='color:#888888'>David<o:p></o:p></span></p></div></div></div><div><div><div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p><div><p class=MsoNormal><span style='color:black'>On Fri, Nov 20, 2015 at 9:20 AM, Betul Buyukkurt <</span><a href="mailto:betulb@codeaurora.org" target="_blank">betulb@codeaurora.org</a><span style='color:black'>> wrote:<o:p></o:p></span></p><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'><p class=MsoNormal><span style='color:black'>Hi Daniel,<br><br>This was the merging of a runtime support of the value profiling feature which was merged along w/ the LLVM and clang counterparts of this work. Those were r253484 and r253485 respectively.<br><br>It looks like that the references to __sycn_fetch_and_add operations are not defined for your target. Is there an alternative that you'd like us to use (mutex lock/unlock based operation)?<br></span><span style='color:#888888'><br>-Betul</span><span style='color:black'><o:p></o:p></span></p><div><div><p class=MsoNormal style='margin-bottom:12.0pt'><span style='color:black'><br>-----Original Message-----<br>From: Daniel Sanders [mailto:</span><a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a><span style='color:black'>]<br>Sent: Friday, November 20, 2015 8:29 AM<br>To: Daniel Sanders; Renato Golin; Betul Buyukkurt; Xinliang David Li; </span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><span style='color:black'><br>Subject: RE: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<br><br>Not sure why I re-added (Outlook removes the list) llvm-dev instead of llvm-commits on that last one, sorry.<br><br>I missed a few fixup commits in the last list. Reverting r253545, r253510, r253508, r253503, r253500, r253496, r253492, r253489, and r253483 (all of which are part of this commit and the corrections) fixes the failing tests in my working copy. I'm going to do a full 'ninja check-all' before I revert.<br><br>> -----Original Message-----<br>> From: llvm-dev [mailto:</span><a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a><span style='color:black'>] On Behalf Of<br>> Daniel Sanders via llvm-dev<br>> Sent: 20 November 2015 16:05<br>> To: Renato Golin; Betul Buyukkurt; </span><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><span style='color:black'>; Xinliang<br>> David Li<br>> Subject: Re: [llvm-dev] [compiler-rt] r253483 - [PGO] Runtime support<br>> for value profiling.<br>><br>> Hi,<br>><br>> I'm currently bisecting a buildbot regression in the clang-cmake-mips<br>> builder and I've ended up with a range of commits, all of them are<br>> either this commit or one of its corrections. The commits are r253483,<br>> r253489, r253492, and r253496. I'm going to try reverting these in my<br>> working copy and if that works I'll commit the revert.<br>><br>> The first build to fail is<br>> </span><a href="http://lab.llvm.org:8011/builders/clang-cmake-" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-</a><span style='color:black'><br>> mips/builds/10816 and the first one to show the current failures is<br>> </span><a href="http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/10819" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/10819</a><span style='color:black'>.<br>><br>> > -----Original Message-----<br>> > From: llvm-commits [mailto:</span><a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a><span style='color:black'>] On<br>> Behalf<br>> > Of Renato Golin via llvm-commits<br>> > Sent: 18 November 2015 21:46<br>> > To: Betul Buyukkurt<br>> > Cc: LLVM Commits<br>> > Subject: Re: [compiler-rt] r253483 - [PGO] Runtime support for value<br>> > profiling.<br>> ><br>> > On 18 November 2015 at 18:12, Betul Buyukkurt via llvm-commits<br>> > <</span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><span style='color:black'>> wrote:<br>> > > Author: betulb<br>> > > Date: Wed Nov 18 12:12:35 2015<br>> > > New Revision: 253483<br>> > ><br>> > > URL: </span><a href="http://llvm.org/viewvc/llvm-project?rev=253483&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253483&view=rev</a><span style='color:black'><br>> > > Log:<br>> > > [PGO] Runtime support for value profiling.<br>> > ><br>> > > This change adds extends the data structures and adds in the<br>> > > routines for handling runtime calls for value profiling. The<br>> > > profile data format is modified and the version number is incremented.<br>> ><br>> > Hi Betul,<br>> ><br>> > There has been a good number of commits and the self-hosting bots<br>> > are still broken, shouldn't we revert everything and try again,<br>> > *after* you make it self-host locally?<br>> ><br>> > </span><a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/</a><span style='color:black'><br>> > 9175<br>> ><br>> > You're making it very hard to revert this patch already...<br>> ><br>> > cheers,<br>> > --renato<br>> > _______________________________________________<br>> > llvm-commits mailing list<br>> > </span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><span style='color:black'><br>> > </span><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><span style='color:black'><br>> _______________________________________________<br>> LLVM Developers mailing list<br>> </span><a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><span style='color:black'><br>> </span><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><span style='color:black'><o:p></o:p></span></p></div></div></blockquote></div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div></div></div></blockquote></div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div></div></div></div></div></div></div></div></div></div></blockquote></div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div></div></div></blockquote></div><p class=MsoNormal><span style='color:black'><o:p> </o:p></span></p></div></div></div></div></div></body></html>