<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Just to let you know: As of r<font size="2"><span style="font-size:10pt;">253681 the failure changed. It gets past the compilation failure now but I can't tell if the current failure
is related to your change or something else that happened in the few days the build was red.<br>
<br>
See <a href="http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6638" target="_blank">
http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6638</a> for the log that tested that commit.<br>
</span></font>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF180668"><font face="Tahoma" color="#000000" size="2"><b>From:</b> Xinliang David Li [xinliangli@gmail.com]<br>
<b>Sent:</b> 20 November 2015 19:21<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> Betul Buyukkurt; llvm-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">I happen to have a pending clean up patch that should fix the problem. Patch coming soon ..
<div><br>
</div>
<div>David</div>
<div><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Nov 20, 2015 at 11:16 AM, Xinliang David Li <span dir="ltr">
<<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">Let me take a look.<span class="HOEnZb"><font color="#888888">
<div><br>
</div>
<div>David</div>
</font></span></div>
<div class="HOEnZb">
<div class="h5">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Nov 20, 2015 at 11:05 AM, Daniel Sanders <span dir="ltr">
<<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">r253687 has done the trick. Thanks.<br>
<br>
<font size="2"><span style="font-size:10pt">I think that just leaves sanitizer_x86_64-freebsd which is failing (</span></font><font size="2"><span style="font-size:10pt"><font size="2"><span style="font-size:10pt"><a href="http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6637/steps/compile/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/sanitizer_x86_64-freebsd/builds/6637/steps/compile/logs/stdio</a>)
</span></font>with errors of the form: </span></font><br>
<pre><span>In file included from /usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfilingBuffer.c:10:
/usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfiling.h:58:9: error: unknown type name 'uint8_t'
const uint8_t *FunctionPointer;
In file included from /usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfilingFile.c:10:
/usr/home/buildslave/slave_as-bldslv5/sanitizer_x86_64-freebsd/llvm.src/projects/compiler-rt/lib/profile/InstrProfiling.h:58:9: error: unknown type name 'uint8_t'
^
const uint8_t *FunctionPointer;
^<br><br>I'm not sure who can help you with this one.<br></span></pre>
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr>
<div style="direction:ltr"><font face="Tahoma" color="#000000" size="2"><b>From:</b> Daniel Sanders<br>
<b>Sent:</b> 20 November 2015 18:47<br>
<b>To:</b> Xinliang David Li; Betul Buyukkurt; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">
llvm-commits@lists.llvm.org</a>
<div>
<div><br>
<b>Subject:</b> RE: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<br>
</div>
</div>
</font><br>
</div>
<div>
<div>
<div></div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Sure, I see you've committed it and I'd test it on the same machine as that builder so I'll keep an eye on that build for now.<br>
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr>
<div style="direction:ltr"><font face="Tahoma" color="#000000" size="2"><b>From:</b> Xinliang David Li [<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>]<br>
<b>Sent:</b> 20 November 2015 17:42<br>
<b>To:</b> Betul Buyukkurt; Daniel Sanders<br>
<b>Subject:</b> Re: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">Daniel, can you help test the following small patch?
<div><br>
</div>
<div>thanks,</div>
<div><br>
</div>
<div>David</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Nov 20, 2015 at 9:36 AM, Xinliang David Li <span dir="ltr">
<<a href="mailto:xinliangli@gmail.com" target="_blank">xinliangli@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div dir="ltr">Or disable value profiling for those targets -- such as stub out the __llvm_profile_instrument_target..
<div><br>
</div>
<div>I can help with a patch for Daniel to test.</div>
<span><font color="#888888">
<div><br>
</div>
<div>
<div><br>
</div>
<div>David</div>
</div>
</font></span></div>
<div>
<div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Nov 20, 2015 at 9:20 AM, Betul Buyukkurt <span dir="ltr">
<<a href="mailto:betulb@codeaurora.org" target="_blank">betulb@codeaurora.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
Hi Daniel,<br>
<br>
This was the merging of a runtime support of the value profiling feature which was merged along w/ the LLVM and clang counterparts of this work. Those were r253484 and r253485 respectively.<br>
<br>
It looks like that the references to __sycn_fetch_and_add operations are not defined for your target. Is there an alternative that you'd like us to use (mutex lock/unlock based operation)?<br>
<span><font color="#888888"><br>
-Betul<br>
</font></span>
<div>
<div><br>
-----Original Message-----<br>
From: Daniel Sanders [mailto:<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>]<br>
Sent: Friday, November 20, 2015 8:29 AM<br>
To: Daniel Sanders; Renato Golin; Betul Buyukkurt; Xinliang David Li; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">
llvm-commits@lists.llvm.org</a><br>
Subject: RE: [compiler-rt] r253483 - [PGO] Runtime support for value profiling.<br>
<br>
Not sure why I re-added (Outlook removes the list) llvm-dev instead of llvm-commits on that last one, sorry.<br>
<br>
I missed a few fixup commits in the last list. Reverting r253545, r253510, r253508, r253503, r253500, r253496, r253492, r253489, and r253483 (all of which are part of this commit and the corrections) fixes the failing tests in my working copy. I'm going to
do a full 'ninja check-all' before I revert.<br>
<br>
> -----Original Message-----<br>
> From: llvm-dev [mailto:<a href="mailto:llvm-dev-bounces@lists.llvm.org" target="_blank">llvm-dev-bounces@lists.llvm.org</a>] On Behalf Of<br>
> Daniel Sanders via llvm-dev<br>
> Sent: 20 November 2015 16:05<br>
> To: Renato Golin; Betul Buyukkurt; <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">
llvm-dev@lists.llvm.org</a>; Xinliang<br>
> David Li<br>
> Subject: Re: [llvm-dev] [compiler-rt] r253483 - [PGO] Runtime support<br>
> for value profiling.<br>
><br>
> Hi,<br>
><br>
> I'm currently bisecting a buildbot regression in the clang-cmake-mips<br>
> builder and I've ended up with a range of commits, all of them are<br>
> either this commit or one of its corrections. The commits are r253483,<br>
> r253489, r253492, and r253496. I'm going to try reverting these in my<br>
> working copy and if that works I'll commit the revert.<br>
><br>
> The first build to fail is<br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-" rel="noreferrer" target="_blank">
http://lab.llvm.org:8011/builders/clang-cmake-</a><br>
> mips/builds/10816 and the first one to show the current failures is<br>
> <a href="http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/10819" rel="noreferrer" target="_blank">
http://lab.llvm.org:8011/builders/clang-cmake-mips/builds/10819</a>.<br>
><br>
> > -----Original Message-----<br>
> > From: llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>] On<br>
> Behalf<br>
> > Of Renato Golin via llvm-commits<br>
> > Sent: 18 November 2015 21:46<br>
> > To: Betul Buyukkurt<br>
> > Cc: LLVM Commits<br>
> > Subject: Re: [compiler-rt] r253483 - [PGO] Runtime support for value<br>
> > profiling.<br>
> ><br>
> > On 18 November 2015 at 18:12, Betul Buyukkurt via llvm-commits<br>
> > <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> > > Author: betulb<br>
> > > Date: Wed Nov 18 12:12:35 2015<br>
> > > New Revision: 253483<br>
> > ><br>
> > > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253483&view=rev" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=253483&view=rev</a><br>
> > > Log:<br>
> > > [PGO] Runtime support for value profiling.<br>
> > ><br>
> > > This change adds extends the data structures and adds in the<br>
> > > routines for handling runtime calls for value profiling. The<br>
> > > profile data format is modified and the version number is incremented.<br>
> ><br>
> > Hi Betul,<br>
> ><br>
> > There has been a good number of commits and the self-hosting bots<br>
> > are still broken, shouldn't we revert everything and try again,<br>
> > *after* you make it self-host locally?<br>
> ><br>
> > <a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/" rel="noreferrer" target="_blank">
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/</a><br>
> > 9175<br>
> ><br>
> > You're making it very hard to revert this patch already...<br>
> ><br>
> > cheers,<br>
> > --renato<br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</body>
</html>