<p dir="ltr">I assume report_fatal_error is noreturn? So we could reorder this to reduce indentation:</p>
<p dir="ltr">if (not normal file)<br>
  Report<br>
If (load library)<br>
  Report</p>
<div class="gmail_quote">On Nov 20, 2015 10:00 PM, "Davide Italiano via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Fri Nov 20 23:58:19 2015<br>
New Revision: 253767<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253767&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253767&view=rev</a><br>
Log:<br>
[llvm-rtdyld] Fail early if we can't load dynamic libraries.<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp?rev=253767&r1=253766&r2=253767&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp?rev=253767&r1=253766&r2=253767&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp (original)<br>
+++ llvm/trunk/tools/llvm-rtdyld/llvm-rtdyld.cpp Fri Nov 20 23:58:19 2015<br>
@@ -250,10 +250,9 @@ static void loadDylibs() {<br>
     if (sys::fs::is_regular_file(Dylib)) {<br>
       std::string ErrMsg;<br>
       if (sys::DynamicLibrary::LoadLibraryPermanently(Dylib.c_str(), &ErrMsg))<br>
-        llvm::errs() << "Error loading '" << Dylib << "': "<br>
-                     << ErrMsg << "\n";<br>
+        report_fatal_error("Error loading '" + Dylib + "': " + ErrMsg);<br>
     } else<br>
-      llvm::errs() << "Dylib not found: '" << Dylib << "'.\n";<br>
+      report_fatal_error("Dylib not found: '" + Dylib + "'.");<br>
   }<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>