<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 20, 2015 at 2:55 PM, Anna Zaks via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zaks<br>
Date: Fri Nov 20 16:55:22 2015<br>
New Revision: 253729<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253729&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253729&view=rev</a><br>
Log:<br>
[asan] Disable the test on i386 Darwin.<br>
<br>
This test checks if we can print a backtrace from the death callback. On old<br>
OS X versions, backtrace is not able to symbolicate the trace past the ASan<br>
runtime because we build with -fomit-frame-pointer.<br>
<br>
Modified:<br>
    compiler-rt/trunk/test/asan/TestCases/Darwin/crashlog-stacktraces.c<br>
<br>
Modified: compiler-rt/trunk/test/asan/TestCases/Darwin/crashlog-stacktraces.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Darwin/crashlog-stacktraces.c?rev=253729&r1=253728&r2=253729&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Darwin/crashlog-stacktraces.c?rev=253729&r1=253728&r2=253729&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/asan/TestCases/Darwin/crashlog-stacktraces.c (original)<br>
+++ compiler-rt/trunk/test/asan/TestCases/Darwin/crashlog-stacktraces.c Fri Nov 20 16:55:22 2015<br>
@@ -1,6 +1,11 @@<br>
 // RUN: %clang_asan -O0 %s -o %t<br>
 // RUN: not %run %t 2>&1 | FileCheck %s<br>
<br>
+// Since ASan is built with -fomit-frame-pointer, backtrace is not able to<br>
+// symbolicate the trace past ASan runtime on i386. (This is fixed in<br>
+// latest OS X.)<br></blockquote><div><br></div><div>"latest" will mean different things at different times. Can you give a concrete version here instead?</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+// REQUIRES: asan-64-bits<br>
+<br>
 #include <execinfo.h><br>
 #include <sanitizer/common_interface_defs.h><br>
 #include <stdio.h><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>