<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 20, 2015 at 11:43 AM, Duncan P. N. Exon Smith via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=llvm-commits@lists.llvm.org&cc=&bcc=&su=&body=','_blank');return false;">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2015-Nov-19, at 14:11, Alexey Samsonov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=llvm-commits@lists.llvm.org&cc=&bcc=&su=&body=','_blank');return false;">llvm-commits@lists.llvm.org</a>> wrote:<br>
><br>
> Author: samsonov<br>
> Date: Thu Nov 19 16:11:10 2015<br>
> New Revision: 253608<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253608&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253608&view=rev</a><br>
> Log:<br>
> Tell clang-format that (most) sanitizers are written using Google style guide.<br>
<br>
</span>I'm guessing this isn't a change of policy, but I didn't know about it.<br>
Why don't they use the LLVM style?</blockquote><div><br></div><div>Because they were initially developed outside of the llvm tree, we were not even sure the code will be ever accepted. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Is that documented in the coding<br>
standards?  </blockquote><div>no </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Should it be?<br></blockquote><div><br></div><div>I don't think so. </div><div>I believe the coding style already tells to use whatever style is in use in a given file. </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
><br>
> Added:<br>
>    compiler-rt/trunk/lib/asan/.clang-format<br>
>    compiler-rt/trunk/lib/dfsan/.clang-format<br>
>    compiler-rt/trunk/lib/interception/.clang-format<br>
>    compiler-rt/trunk/lib/lsan/.clang-format<br>
>    compiler-rt/trunk/lib/msan/.clang-format<br>
>    compiler-rt/trunk/lib/safestack/.clang-format<br>
>    compiler-rt/trunk/lib/sanitizer_common/.clang-format<br>
>    compiler-rt/trunk/lib/tsan/.clang-format<br>
><br>
> Added: compiler-rt/trunk/lib/asan/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/asan/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/asan/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/dfsan/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/dfsan/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/dfsan/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/dfsan/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/dfsan/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/interception/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/interception/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/interception/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/interception/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/interception/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/lsan/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/lsan/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/lsan/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/lsan/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/lsan/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/msan/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/msan/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/msan/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/safestack/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/safestack/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/safestack/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/safestack/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/safestack/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/sanitizer_common/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/sanitizer_common/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/sanitizer_common/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
> Added: compiler-rt/trunk/lib/tsan/.clang-format<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/.clang-format?rev=253608&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/.clang-format?rev=253608&view=auto</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/tsan/.clang-format (added)<br>
> +++ compiler-rt/trunk/lib/tsan/.clang-format Thu Nov 19 16:11:10 2015<br>
> @@ -0,0 +1 @@<br>
> +BasedOnStyle: Google<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=llvm-commits@lists.llvm.org&cc=&bcc=&su=&body=','_blank');return false;">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" onclick="window.open('https://mail.google.com/mail/?view=cm&tf=1&to=llvm-commits@lists.llvm.org&cc=&bcc=&su=&body=','_blank');return false;">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>