<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 19, 2015 at 11:28 AM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Thu Nov 19 13:28:23 2015<br>
New Revision: 253591<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253591&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253591&view=rev</a><br>
Log:<br>
[AddressSanitizer] assert(false) -> llvm_unreachable and remove return.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=253591&r1=253590&r2=253591&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=253591&r1=253590&r2=253591&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Thu Nov 19 13:28:23 2015<br>
@@ -1216,10 +1216,8 @@ bool AddressSanitizerModule::ShouldInstr<br>
       bool TAAParsed;<br>
       std::string ErrorCode = MCSectionMachO::ParseSectionSpecifier(<br>
           Section, ParsedSegment, ParsedSection, TAA, TAAParsed, StubSize);<br>
-      if (!ErrorCode.empty()) {<br>
-        assert(false && "Invalid section specifier.");<br>
-        return false;<br>
-      }<br>
+      if (!ErrorCode.empty())<br>
+        llvm_unreachable("Invalid section specifier.");<br></blockquote><div><br></div><div>This looks like it should just be an assertion:<br><br>assert(ErrorCode.empty() && "Invalid section specifier.");</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
       // Ignore the globals from the __OBJC section. The ObjC runtime assumes<br>
       // those conform to /usr/lib/objc/runtime.h, so we can't add redzones to<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>