<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">No, such test would be very fragile, it crashes only depending on what the inliner decides to do after GVN.<div class="">I hesitated about a c++ unit test that would verify the returned value on this IR fed to GVN, but it does not seems “usual”.</div><div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""></div><div class=""><div class=""><br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 18, 2015, at 5:08 PM, Daniel Berlin <<a href="mailto:dberlin@dberlin.org" class="">dberlin@dberlin.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">DId the test case for this get committed?<div class="">(it was a crasher, so it should crash before the fix and not crash after).</div><div class=""><br class=""></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Nov 18, 2015 at 5:00 PM, Mehdi AMINI via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">joker.eph added a subscriber: joker.eph.<br class="">
joker.eph added auditors: 3.7-release, llvm-commits, tstellarAMD.<br class="">
joker.eph added a comment.<br class="">
<br class="">
This is very low risk and fix potential bug/crash.<br class="">
<br class="">
<br class="">
Users:<br class="">
3.7-release (Auditor)<br class="">
llvm-commits (Auditor)<br class="">
tstellarAMD (Auditor)<br class="">
<br class="">
<a href="http://reviews.llvm.org/rL253518" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/rL253518</a><br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></div></body></html>