<div dir="ltr">Thanks! This also breaks several UBSan tests: UBSan uses Demangle function to restore type names, they don't start with _Z.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Nov 14, 2015 at 2:42 AM, Kuba Brecka via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kuba.brecka<br>
Date: Sat Nov 14 04:42:08 2015<br>
New Revision: 253129<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253129&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253129&view=rev</a><br>
Log:<br>
Reverting r253080 ([tsan] Don't demangle names not starting with "_Z").<br>
<br>
This caused bot failures on ARM, e.g. <a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/9068" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/9068</a><br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc<br>
    compiler-rt/trunk/test/tsan/Darwin/symbolizer-dladdr.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc?rev=253129&r1=253128&r2=253129&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc?rev=253129&r1=253128&r2=253129&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc Sat Nov 14 04:42:08 2015<br>
@@ -48,9 +48,6 @@ namespace __sanitizer {<br>
<br>
 // Attempts to demangle the name via __cxa_demangle from __cxxabiv1.<br>
 const char *DemangleCXXABI(const char *name) {<br>
-  if (name[0] != '_' || name[1] != 'Z')<br>
-    return name;<br>
-<br>
   // FIXME: __cxa_demangle aggressively insists on allocating memory.<br>
   // There's not much we can do about that, short of providing our<br>
   // own demangler (libc++abi's implementation could be adapted so that<br>
<br>
Modified: compiler-rt/trunk/test/tsan/Darwin/symbolizer-dladdr.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/symbolizer-dladdr.cc?rev=253129&r1=253128&r2=253129&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/Darwin/symbolizer-dladdr.cc?rev=253129&r1=253128&r2=253129&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/Darwin/symbolizer-dladdr.cc (original)<br>
+++ compiler-rt/trunk/test/tsan/Darwin/symbolizer-dladdr.cc Sat Nov 14 04:42:08 2015<br>
@@ -3,12 +3,10 @@<br>
 #include "../test.h"<br>
<br>
 int GlobalData[10];<br>
-long long x;<br>
<br>
 void *Thread(void *a) {<br>
   barrier_wait(&barrier);<br>
   GlobalData[2] = 42;<br>
-  x = 7;<br>
   return 0;<br>
 }<br>
<br>
@@ -20,7 +18,6 @@ int main() {<br>
   pthread_t t;<br>
   pthread_create(&t, 0, Thread, 0);<br>
   GlobalData[2] = 43;<br>
-  x = 8;<br>
   barrier_wait(&barrier);<br>
   pthread_join(t, 0);<br>
 }<br>
@@ -30,5 +27,3 @@ int main() {<br>
 // CHECK: addr=[[ADDR:0x[0-9,a-f]+]]<br>
 // CHECK: WARNING: ThreadSanitizer: data race<br>
 // CHECK: Location is global 'GlobalData' at [[ADDR]] ({{.*}}+0x{{[0-9,a-f]+}})<br>
-// CHECK: WARNING: ThreadSanitizer: data race<br>
-// CHECK: Location is global 'x' at {{.*}} ({{.*}}+0x{{[0-9,a-f]+}})<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div>