<div dir="ltr">The iterator based removeSuccessor does the check already.<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 17, 2015 at 10:32 PM, Philip Reames via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 11/17/2015 05:55 PM, Cong Hou via llvm-commits wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: conghou<br>
Date: Tue Nov 17 19:55:56 2015<br>
New Revision: 253426<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253426&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253426&view=rev</a><br>
Log:<br>
Remove a redundant assertion in MachineBasicBlock.cpp. NFC.<br>
<br>
<br>
Modified:<br>
     llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp?rev=253426&r1=253425&r2=253426&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp?rev=253426&r1=253425&r2=253426&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/MachineBasicBlock.cpp Tue Nov 17 19:55:56 2015<br>
@@ -545,7 +545,6 @@ void MachineBasicBlock::addSuccessorWith<br>
    void MachineBasicBlock::removeSuccessor(MachineBasicBlock *Succ) {<br>
    succ_iterator I = std::find(Successors.begin(), Successors.end(), Succ);<br>
-  assert(I != Successors.end() && "Not a current successor!");<br>
</blockquote></span>
Why is this redundant?  It appears to be checking whether Succ is actually a successor of this.  That seems useful to say the least?<div class="HOEnZb"><div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
    removeSuccessor(I);<br>
  }<br>
  <br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>