<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 13, 2015 at 9:06 AM, Tom Stellard via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: tstellar<br>
Date: Fri Nov 13 11:06:29 2015<br>
New Revision: 253052<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=253052&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=253052&view=rev</a><br>
Log:<br>
ELFYAML: Add support for parsing AMDGPU section attribute flags<br>
<br>
Reviewers: silvas<br>
<br>
Subscribers: llvm-commits<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D14444" rel="noreferrer" target="_blank">http://reviews.llvm.org/D14444</a><br>
<br>
Modified:<br>
    llvm/trunk/lib/Object/ELFYAML.cpp<br>
    llvm/trunk/test/Object/AMDGPU/elf-definitios.yaml<br></blockquote><div><br></div><div>This file name seems to have a typo.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified: llvm/trunk/lib/Object/ELFYAML.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ELFYAML.cpp?rev=253052&r1=253051&r2=253052&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/ELFYAML.cpp?rev=253052&r1=253051&r2=253052&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Object/ELFYAML.cpp (original)<br>
+++ llvm/trunk/lib/Object/ELFYAML.cpp Fri Nov 13 11:06:29 2015<br>
@@ -402,6 +402,7 @@ void ScalarEnumerationTraits<ELFYAML::EL<br>
<br>
 void ScalarBitSetTraits<ELFYAML::ELF_SHF>::bitset(IO &IO,<br>
                                                   ELFYAML::ELF_SHF &Value) {<br>
+  const auto *Object = static_cast<ELFYAML::Object *>(IO.getContext());<br>
 #define BCase(X) IO.bitSetCase(Value, #X, ELF::X);<br>
   BCase(SHF_WRITE)<br>
   BCase(SHF_ALLOC)<br>
@@ -414,6 +415,17 @@ void ScalarBitSetTraits<ELFYAML::ELF_SHF<br>
   BCase(SHF_OS_NONCONFORMING)<br>
   BCase(SHF_GROUP)<br>
   BCase(SHF_TLS)<br>
+  switch(Object->Header.Machine) {<br>
+  case ELF::EM_AMDGPU:<br>
+    BCase(SHF_AMDGPU_HSA_GLOBAL)<br>
+    BCase(SHF_AMDGPU_HSA_READONLY)<br>
+    BCase(SHF_AMDGPU_HSA_CODE)<br>
+    BCase(SHF_AMDGPU_HSA_AGENT)<br>
+    break;<br>
+  default:<br>
+    // Nothing to do.<br>
+    break;<br>
+  }<br>
 #undef BCase<br>
 }<br>
<br>
<br>
Modified: llvm/trunk/test/Object/AMDGPU/elf-definitios.yaml<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/AMDGPU/elf-definitios.yaml?rev=253052&r1=253051&r2=253052&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/AMDGPU/elf-definitios.yaml?rev=253052&r1=253051&r2=253052&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/Object/AMDGPU/elf-definitios.yaml (original)<br>
+++ llvm/trunk/test/Object/AMDGPU/elf-definitios.yaml Fri Nov 13 11:06:29 2015<br>
@@ -1,7 +1,16 @@<br>
 # RUN: yaml2obj -format=elf %s > %t.o<br>
-# RUN: llvm-readobj -file-headers %t.o | FileCheck %s<br>
+# RUN: llvm-readobj -s -file-headers %t.o | FileCheck %s<br>
<br>
 # CHECK:  Machine: EM_AMDGPU (0xE0)<br>
+# CHECK: Sections [<br>
+# CHECK: Section {<br>
+# CHECK: Name: .shf_amdgpu<br>
+# CHECK: Flags [ (0xF00000)<br>
+# CHECK: SHF_AMDGPU_HSA_AGENT (0x800000)<br>
+# CHECK: SHF_AMDGPU_HSA_CODE (0x400000)<br>
+# CHECK: SHF_AMDGPU_HSA_GLOBAL (0x100000)<br>
+# CHECK: SHF_AMDGPU_HSA_READONLY (0x200000)<br>
+# CHECK: }<br>
<br>
 ---<br>
 FileHeader:<br>
@@ -9,4 +18,10 @@ FileHeader:<br>
   Data:    ELFDATA2LSB<br>
   Type:    ET_REL<br>
   Machine: EM_AMDGPU<br>
+<br>
+Sections:<br>
+  - Name:  .shf_amdgpu<br>
+    Type:  SHT_PROGBITS<br>
+    Flags: [ SHF_AMDGPU_HSA_GLOBAL, SHF_AMDGPU_HSA_READONLY,<br>
+             SHF_AMDGPU_HSA_CODE, SHF_AMDGPU_HSA_AGENT]<br>
 ...<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>