<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 13, 2015, at 7:58 AM, Daniel Berlin <<a href="mailto:dberlin@dberlin.org" class="">dberlin@dberlin.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Nov 12, 2015 at 11:55 PM, Owen Anderson <span dir="ltr" class=""><<a href="mailto:resistor@mac.com" target="_blank" class="">resistor@mac.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">resistor added a comment.<br class="">
<span class=""><br class="">
In <a href="http://reviews.llvm.org/D12345#288471" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D12345#288471</a>, @dberlin wrote:<br class="">
<br class="">
</span>Would it be reasonable to stage that investigation? AFAICT the changes already proposed (with Chad's comments incorporated) are a strict improvement, and I at least am seeing pretty severe performance regressions from their absence. Would you be alright with going ahead and landing those?<br class=""></blockquote><div class=""><br class=""></div><div class=""><br class=""></div><div class="">I'm not opposed, I'd like to see compile time numbers first since it transforms reassociate into an iterative algorithm.</div></div></div></div></div></blockquote><div><br class=""></div><div>I’ll see what I can get you on that.</div><br class=""><blockquote type="cite" class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">For my use case, at least, N-ary reassociation is not really appropriate as I also heavily depend on reassociation of floating point arithmetic. </blockquote><div class=""><br class=""></div><div class="">I'm not sure why these two statements go together ;-)</div><div class="">What am i missing?</div></div></div></div></blockquote><div><br class=""></div><div>N-ary reassociation depends heavily on SCEV, both in practice and according to Jingyue’s design doc. SCEV does not work on floating point today, and it seems has an immense undertaking to get it to work on it.</div><div><br class=""></div><div>—Owen</div></div></body></html>