<div dir="ltr">Can we have if (SANITIZER_GO) instead of "#if SANITIZER_GO" here? <div>I know it is not always possible, but here it should be. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 12, 2015 at 6:03 AM, Dmitry Vyukov via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Thu Nov 12 08:03:20 2015<br>
New Revision: 252892<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=252892&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=252892&view=rev</a><br>
Log:<br>
tsan: disable abort_on_error for Go<br>
<br>
It does not work as expected.<br>
Go runtime handles SIGABRT and crashes with a loud message.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc?rev=252892&r1=252891&r2=252892&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc?rev=252892&r1=252891&r2=252892&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_flags.cc Thu Nov 12 08:03:20 2015<br>
@@ -61,7 +61,11 @@ void InitializeFlags(Flags *f, const cha<br>
     CommonFlags cf;<br>
     cf.CopyFrom(*common_flags());<br>
     cf.allow_addr2line = true;<br>
-#ifndef SANITIZER_GO<br>
+#ifdef SANITIZER_GO<br>
+    // Does not work as expected for Go: runtime handles SIGABRT and crashes.<br>
+    cf.abort_on_error = false;<br>
+    // Go does not have mutexes.<br>
+#else<br>
     cf.detect_deadlocks = true;<br>
 #endif<br>
     cf.print_suppressions = false;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>