<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 11, 2015 at 11:34 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank" class="cremed">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Wed, Nov 11, 2015 at 8:14 AM, Diego Novillo via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: dnovillo<br>
Date: Wed Nov 11 10:14:52 2015<br>
New Revision: 252748<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=252748&view=rev" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=252748&view=rev</a><br>
Log:<br>
Remove unused variable in disable-assert builds.  NFC.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=252748&r1=252747&r2=252748&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=252748&r1=252747&r2=252748&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Wed Nov 11 10:14:52 2015<br>
@@ -9141,8 +9141,7 @@ static SDValue PerformBFICombine(SDNode<br>
     SDValue From1 = ParseBFI(N, ToMask1, FromMask1);<br>
<br>
     APInt ToMask2, FromMask2;<br>
-    SDValue From2 = ParseBFI(CombineBFI.getNode(), ToMask2, FromMask2);<br>
-    assert(From1 == From2);<br>
+    assert(From1 == ParseBFI(CombineBFI.getNode(), ToMask2, FromMask2));<br></blockquote><div><br></div></span><div>This looks like the wrong transformation - presumably ParseBFI has side effects, like parsing the result into ToMask2 and FromMask2 - putting it inside the assert means those side effects will not be performed in a -Asserts build.<br><br>The right thing in this instance is probably to add a (void)From2; statement either before or after the assert (we're not terribly consistent about whether it goes before or after)<br></div></div></div></div></blockquote><div><br></div><div>Thanks, Dave.  I wasn't paying attention.  Fixed at r252751.</div><div></div></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">Diego.</div></div>