<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Hi Diego,
<div class=""><br class="">
</div>
<div class="">Thanks for sorting this out. Apologies, I was away from my computer during the whole incident!</div>
<div class=""><br class="">
</div>
<div class="">I’m surprised no buildbots are running a release-no-asserts build - strange.</div>
<div class=""><br class="">
</div>
<div class="">Cheers,</div>
<div class=""><br class="">
</div>
<div class="">James<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On 11 Nov 2015, at 16:33, Diego Novillo <<a href="mailto:dnovillo@google.com" class="">dnovillo@google.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">James,
<div class=""><br class="">
</div>
<div class="">My fix is actually not correct here. The call to ParseBFI() clearly has side-effects that go beyond the assert (<a href="http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/29845/steps/test_llvm/logs/LLVM%20%3A%3A%20CodeGen__ARM__bfi.ll" class="">http://bb.pgr.jp/builders/cmake-llvm-x86_64-linux/builds/29845/steps/test_llvm/logs/LLVM%20%3A%3A%20CodeGen__ARM__bfi.ll</a>).</div>
<div class=""><br class="">
</div>
<div class="">Variable From2 goes unused in disable-assert builds. This is breaking our internal builds.</div>
<div class=""><br class="">
</div>
<div class="">Could you please suggest a fix that will fix the disable-assert case?</div>
<div class=""><br class="">
</div>
<div class="">Thanks. Diego.</div>
<div class=""><br class="">
</div>
</div>
<div class="gmail_extra"><br class="">
<div class="gmail_quote">On Wed, Nov 11, 2015 at 11:14 AM, Diego Novillo via llvm-commits
<span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dnovillo<br class="">
Date: Wed Nov 11 10:14:52 2015<br class="">
New Revision: 252748<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=252748&view=rev" rel="noreferrer" target="_blank" class="">
http://llvm.org/viewvc/llvm-project?rev=252748&view=rev</a><br class="">
Log:<br class="">
Remove unused variable in disable-assert builds. NFC.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=252748&r1=252747&r2=252748&view=diff" rel="noreferrer" target="_blank" class="">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=252748&r1=252747&r2=252748&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)<br class="">
+++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Wed Nov 11 10:14:52 2015<br class="">
@@ -9141,8 +9141,7 @@ static SDValue PerformBFICombine(SDNode<br class="">
SDValue From1 = ParseBFI(N, ToMask1, FromMask1);<br class="">
<br class="">
APInt ToMask2, FromMask2;<br class="">
- SDValue From2 = ParseBFI(CombineBFI.getNode(), ToMask2, FromMask2);<br class="">
- assert(From1 == From2);<br class="">
+ assert(From1 == ParseBFI(CombineBFI.getNode(), ToMask2, FromMask2));<br class="">
<br class="">
// First, unlink CombineBFI.<br class="">
DCI.DAG.ReplaceAllUsesWith(CombineBFI, CombineBFI.getOperand(0));<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
<br>
<hr>
<font face="Arial" color="Black" size="2"><br>
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any
purpose, or store or copy the information in any medium. Thank you.<br>
</font>
</body>
</html>