<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Courier New;color: #000000;font-size: 10pt;">
Hi James,<br>
<br>
I didn't see your comment in phabricator and I accidentally committed this. Do you want me to revert it?<br>
<br>
I was going to say that we use LNT in order to run the LLVM test-suite, and given that CMake isn't supported at the moment, I'd like to have it committed.<br>
<br>
Also, I'd like to use CMake with LNT and it's my intention to send any patch that'll allows us to do that with Musl, when the relevant review requests land.<br>
<br>
Thanks,<br>
Vasileios<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF48078"><font face="Tahoma" color="#000000" size="2"><b>From:</b> James Molloy [james@jamesmolloy.co.uk]<br>
<b>Sent:</b> 10 November 2015 15:15<br>
<b>To:</b> reviews+D13935+public+6985f52afb85db86@reviews.llvm.org; Daniel Sanders; Vasileios Kalintiris<br>
<b>Cc:</b> llvm-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [PATCH] D13935: [minisat] Include the fpu_control.h header only when the __GLIBC__ macro is defined.<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">Hi,
<div><br>
</div>
<div>I'd prefer if we used CMake to check for the existence of the fpu_control.h header - we have a proper configure system now, let's use it!</div>
<div><br>
</div>
<div>#if defined(__GLIBC__) || HAVE_FPU_CONTROL_H , or something?</div>
<div><br>
</div>
<div>Cheers,</div>
<div><br>
</div>
<div>James</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, 10 Nov 2015 at 14:46 Daniel Sanders via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
dsanders added a subscriber: dsanders.<br>
dsanders accepted this revision.<br>
dsanders added a reviewer: dsanders.<br>
dsanders added a comment.<br>
This revision is now accepted and ready to land.<br>
<br>
LGTM with a (possibly unnecessary) nit<br>
<br>
<br>
================<br>
Comment at: MultiSource/Applications/minisat/Main.cpp:79<br>
@@ -78,3 +78,3 @@<br>
<br>
-#if defined(__linux__)<br>
+#if defined(__GLIBC__)<br>
#include <fpu_control.h><br>
----------------<br>
You're probably correct here but I don't know much about the non-linux targets that glibc supports (e.g. Hurd). I'd err on the side of caution and test for both `__linux__` and `__GLIBC__`.<br>
<br>
<br>
<a href="http://reviews.llvm.org/D13935" rel="noreferrer" target="_blank">http://reviews.llvm.org/D13935</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>