<div dir="ltr">We tend not to put multiple statements on the same line (clang-format will split these, for example) - though I don't think there's a massively overriding convention about whether the cast to void should go before or after the assert.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Nov 8, 2015 at 9:47 PM, Colin LeMahieu via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: colinl<br>
Date: Sun Nov  8 23:47:56 2015<br>
New Revision: 252448<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=252448&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=252448&view=rev</a><br>
Log:<br>
[Hexagon] Fixing warnings.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp?rev=252448&r1=252447&r2=252448&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp?rev=252448&r1=252447&r2=252448&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp (original)<br>
+++ llvm/trunk/lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp Sun Nov  8 23:47:56 2015<br>
@@ -87,8 +87,6 @@ class HexagonAsmParser : public MCTarget<br>
   MCAssembler *getAssembler() const { return Assembler; }<br>
   MCAsmLexer &getLexer() const { return Parser.getLexer(); }<br>
<br>
-  unsigned ArchVersion;<br>
-<br>
   bool equalIsAsmAssignment() override { return false; }<br>
   bool isLabel(AsmToken &Token) override;<br>
<br>
@@ -1190,7 +1188,7 @@ bool HexagonAsmParser::isLabel(AsmToken<br>
     return true;<br>
   if (!MatchRegisterName(String.lower()))<br>
     return true;<br>
-  assert(Second.is(AsmToken::Colon));<br>
+  assert(Second.is(AsmToken::Colon)); (void)Second;<br>
   StringRef Raw (String.data(), Third.getString().data() - String.data() +<br>
                  Third.getString().size());<br>
   std::string Collapsed = Raw;<br>
@@ -1566,7 +1564,7 @@ int HexagonAsmParser::processInstruction<br>
     MCOperand &MO = Inst.getOperand(2);<br>
     int64_t Value;<br>
     bool Success = MO.getExpr()->evaluateAsAbsolute(Value);<br>
-    assert(Success && "Assured by matcher");<br>
+    assert(Success && "Assured by matcher"); (void)Success;<br>
     if (Value == 0) {<br>
       MCInst TmpInst;<br>
       MCOperand &Pd = Inst.getOperand(0);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>