<div dir="ltr">I did LGTM this one specifically - I see it in the same mail thread.<div><br></div><div>I felt the behaviour was obvious and shouldn't depend on ObjC selector support - it looks correct according to LangRef.</div><div><br></div><div>However if you want someone else to chip in I'm not going to stand in your way :)</div><div><br></div><div>James</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, 9 Nov 2015 at 16:33 Oliver Stannard <<a href="mailto:oliver.stannard@arm.com">oliver.stannard@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-GB" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">You LGTM’d a related patch (D13343), I had assumed that you did not review this one because of the CUDA and Objective-C questions (in the phabricator summary).<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Oliver<u></u><u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"><div><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm"><p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> James Molloy [mailto:<a href="mailto:james@jamesmolloy.co.uk" target="_blank">james@jamesmolloy.co.uk</a>] <br><b>Sent:</b> 09 November 2015 16:27<br><b>To:</b> <a href="mailto:reviews%2BD13382%2Bpublic%2Bb1749bb76d44e9b5@reviews.llvm.org" target="_blank">reviews+D13382+public+b1749bb76d44e9b5@reviews.llvm.org</a>; Oliver Stannard; <a href="mailto:tra@google.com" target="_blank">tra@google.com</a>; <a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a><br><b>Cc:</b> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><b>Subject:</b> Re: [PATCH] D13382: GlobalOpt should maintain externally_initialized when splitting aggregates<u></u><u></u></span></p></div></div></div></div></div><div lang="EN-GB" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"><p class="MsoNormal"><u></u> <u></u></p><div><p class="MsoNormal">Hi Oliver,<u></u><u></u></p><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">I did LGTM this on the 19th October. Did you want more reviews?<u></u><u></u></p></div><div><p class="MsoNormal">James<u></u><u></u></p></div></div><p class="MsoNormal"><u></u> <u></u></p><div><div><p class="MsoNormal">On Mon, 9 Nov 2015 at 16:22 Oliver Stannard via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p></div><blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"><p class="MsoNormal">olista01 added reviewers: tra, rsmith.<br>olista01 added a comment.<br><br>Ping? (and adding some reviewers that may be able to answer the question about CUDA and Objective-C)<br><br><br>Repository:<br>  rL LLVM<br><br><a href="http://reviews.llvm.org/D13382" target="_blank">http://reviews.llvm.org/D13382</a><br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p></blockquote></div></div></div></div></blockquote></div>