<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 9, 2015 at 7:37 PM, Andy Ayers <span dir="ltr"><<a href="mailto:andya@microsoft.com" target="_blank">andya@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Or just not cause the problem in the first place... not sure why the builds I did didn’t flag this.</span></p></div></div></blockquote><div><br></div><div>What compiler are you building with? Are you building with -Werror enabled?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><a name="150ef7825d3b300b__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></a></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> David Blaikie [mailto:<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>]
<br>
<b>Sent:</b> Monday, November 9, 2015 7:20 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD14525%2Bpublic%2B44dfeb4c191f02ac@reviews.llvm.org" target="_blank">reviews+D14525+public+44dfeb4c191f02ac@reviews.llvm.org</a>; Andy Ayers <<a href="mailto:andya@microsoft.com" target="_blank">andya@microsoft.com</a>><br>
<b>Cc:</b> llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject:</b> Re: [PATCH] D14525: Remove unused local variable<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">committed something like this along with another fix in <span style="font-family:"Courier New"">252580<br>
<br>
Feel free to just commit stuff like this without review in the future, if you have commit access - it's simple enough.</span><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Nov 9, 2015 at 7:13 PM, Andy Ayers via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">AndyAyers created this revision.<br>
AndyAyers added a subscriber: llvm-commits.<br>
AndyAyers set the repository for this revision to rL LLVM.<br>
<br>
Fix warning caused by unused local variable. NFC.<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2freviews.llvm.org%2fD14525&data=01%7c01%7candya%40microsoft.com%7c6c35e95355f646d9110708d2e97dcd1b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=9a1O9tqqDJ0%2bnD9hkUoLvhpU9lgzu35tyd13Jn4vOG4%3d" target="_blank">http://reviews.llvm.org/D14525</a><br>
<br>
Files:<br>
lib/Target/X86/X86FrameLowering.cpp<br>
<br>
Index: lib/Target/X86/X86FrameLowering.cpp<br>
===================================================================<br>
--- lib/Target/X86/X86FrameLowering.cpp<br>
+++ lib/Target/X86/X86FrameLowering.cpp<br>
@@ -749,8 +749,8 @@<br>
<br>
assert(InProlog && "ChkStkStub called outside prolog!");<br>
<br>
- MachineInstrBuilder CI = BuildMI(MBB, MBBI, DL, TII.get(X86::CALLpcrel32))<br>
- .addExternalSymbol("__chkstk_stub");<br>
+ BuildMI(MBB, MBBI, DL, TII.get(X86::CALLpcrel32))<br>
+ .addExternalSymbol("__chkstk_stub");<br>
<br>
return MBBI;<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2flists.llvm.org%2fcgi-bin%2fmailman%2flistinfo%2fllvm-commits&data=01%7c01%7candya%40microsoft.com%7c6c35e95355f646d9110708d2e97dcd1b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2fW0XZxv5iWvganxKgsXulMKSZbgHwUMiVLxyECFH7Gw%3d" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div></div>