<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 30, 2015 at 12:18 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It seems it might be avoided in trunk, as far as we are using the module LLVM_Transforms, not individual module per header.<div><br></div><div>For example, ScalarReplAggregates.cpp would fail to build w/o -fcxx-modules with;</div><div>+#include "llvm/Transforms/Scalar/SROA.h"<br></div></div></blockquote><div><br></div><div>I'm still hoping this qualifies as a modules bug, though - it would seem unfortunate to have to worry about all global names when choosing the name of an entity in an anonymous namespace. I only really want to worry about the transitive header inclusions. (though, yes, that does mean someone in a far-flung dependency can have problems because my code depends on them not including that header that does use a name I want to use locally... - so I Could see the counterargument)<br><br>I think Richard provided a workaround/fix for 'local' using declarations and typedefs that might be relevant here - but I could be stretching/associating the wrong things together... <br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div><div>I suggest s/SROA/AnyCoolName/ here. Any better idea?<br></div></div></blockquote><div><br>I believe this code is hopefully going to die in the next few months (according to a chat with Chandler I had at the dev meeting - it's mostly superseded by the actual SROA pass, etc). Maybe we could just replace SROA with SRA in this file? (matching the actual file number)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 27, 2015 at 9:18 AM NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I didn't have time to file the bugzilla about it in the last weekend. Will do later.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 27, 2015 at 7:17 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Oct 26, 2015 at 3:06 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Sat, Oct 24, 2015 at 9:15 AM, David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Oct 23, 2015 at 11:42 PM, NAKAMURA Takumi via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: chapuni<br>
Date: Sat Oct 24 01:42:42 2015<br>
New Revision: 251181<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=251181&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=251181&view=rev</a><br>
Log:<br>
ScalarReplAggregates.cpp: Try to appease clash of anonymous::SROA in modules build.<br></blockquote><div><br></div></span><div>Um... - where's this clashing with? Is there an anonymous namespace with a SROA thing in a header somewhere? That really shouldn't be there. What else would this be colliding with in a modules build?</div></div></div></div></blockquote><div><br></div></span><div>I think what's happening is that this is pulling in a top-level module `LLVM_Transforms` from include/llvm/module.modulemap, which includes llvm/Transforms/Scalar/SROA.h, which defines a class `SROA`. There's probably a missing special case to sprinkle somewhere so that we uphold the weird name hiding thing we do for submodules.</div></div></div></div></blockquote><div><br></div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Yep, possibly - Mr. Smith is out on vacation this week. Hopefully he can weigh in on this next week. But I hope we don't leave that #define around for long. It's pretty awkward.</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp?rev=251181&r1=251180&r2=251181&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp?rev=251181&r1=251180&r2=251181&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Scalar/ScalarReplAggregates.cpp Sat Oct 24 01:42:42 2015<br>
@@ -60,6 +60,7 @@ STATISTIC(NumAdjusted, "Number of scala<br>
STATISTIC(NumConverted, "Number of aggregates converted to scalar");<br>
<br>
namespace {<br>
+#define SROA SROA_<br>
struct SROA : public FunctionPass {<br>
SROA(int T, bool hasDT, char &ID, int ST, int AT, int SLT)<br>
: FunctionPass(ID), HasDomTree(hasDT) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></span></div><br></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></span></div><br></div></div>
</blockquote></div></div></div></blockquote></div></blockquote></div>
</div></div></blockquote></div><br></div></div>