<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""></div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Kuba</div><div class=""><br class=""></div><br class=""><div><blockquote type="cite" class=""><div class="">On 27 Oct 2015, at 17:04, H.J. Lu <<a href="mailto:hjl.tools@gmail.com" class="">hjl.tools@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Tue, Oct 27, 2015 at 4:35 PM, Anna Zaks <</span><a href="mailto:ganna@apple.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">ganna@apple.com</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">> wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">Thanks for helping out!!!<br class=""><br class="">Could you apply the following on top of that:<br class=""><br class="">diff --git a/lib/sanitizer_common/sanitizer_common_nolibc.cc<br class="">b/lib/sanitizer_common/sanitizer_common_nolibc.cc<br class="">index 65d1e37..4115167 100644<br class="">--- a/lib/sanitizer_common/sanitizer_common_nolibc.cc<br class="">+++ b/lib/sanitizer_common/sanitizer_common_nolibc.cc<br class="">@@ -17,10 +17,8 @@<br class=""><br class=""><br class=""><br class="">namespace __sanitizer {<br class=""><br class=""><br class=""><br class="">-#if SANITIZER_LINUX<br class="">void WriteToSyslog(const char *buffer) {}<br class="">-#endif<br class="">-<br class="">+bool ShouldLogAfterPrintf() { return false; }<br class="">void Abort() { internal__exit(1); }<br class=""><br class=""><br class=""><br class="">} // namespace __sanitizer<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">I got</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">[ 96%] Generating ASAN_NOINST_TEST_OBJECTS.asan_noinst_test.cc.i686-inline.o</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">At global scope:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">cc1plus: error: unrecognized command line option</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">\u2018-Wno-unknown-warning-option\u2019 [-Werror]</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">cc1plus: error: unrecognized command line option</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">\u2018-Wno-unused-const-variable\u2019 [-Werror]</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">cc1plus: all warnings being treated as errors</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">On Oct 27, 2015, at 4:28 PM, H.J. Lu <<a href="mailto:hjl.tools@gmail.com" class="">hjl.tools@gmail.com</a>> wrote:<br class=""><br class="">On Tue, Oct 27, 2015 at 3:57 PM, Kuba Brecka <<a href="mailto:jbrecka@apple.com" class="">jbrecka@apple.com</a>> wrote:<br class=""><br class="">It caused:<br class=""><br class="">/tmp/gotsan.wmNri3GVMz/race_linux_amd64.syso: In function<br class="">`__sanitizer::SharedPrintfCode(bool, char const*, __va_list_tag*)':<br class=""><a href="http://gotsan.cc" class="">gotsan.cc</a>:(.text+0x4a85): undefined reference to<br class="">`__sanitizer::WriteToSyslog(char const*)'<br class="">collect2: error: ld returned 1 exit status<br class="">@<br class=""><br class="">on Fedora 22.<br class=""><br class=""><br class="">It looks like the issue is in lib/tsan/go/buildgo.sh, which doesn’t even<br class="">build sanitizer_common_libcdep.cc...<br class=""><br class="">Could you try adding it to buildgo.sh’s list of Linux sources? If the fix<br class="">is not that easy, we can revert this patch, but since this looks like it’s a<br class="">Go-specific Linux-specific failure, it would be great if you could help us<br class="">with triaging the failure.<br class=""><br class="">Thanks,<br class="">Kuba<br class=""><br class=""><br class="">After applying:<br class=""><br class="">diff --git a/lib/tsan/go/buildgo.sh b/lib/tsan/go/buildgo.sh<br class="">index a7e12f1..f34b23c 100755<br class="">--- a/lib/tsan/go/buildgo.sh<br class="">+++ b/lib/tsan/go/buildgo.sh<br class="">@@ -40,6 +40,7 @@ if [ "`uname -a | grep Linux`" != "" ]; then<br class=""> SRCS="<br class=""> $SRCS<br class=""> ../rtl/tsan_platform_linux.cc<br class="">+ ../../sanitizer_common/sanitizer_common_libcdep.cc<br class=""> ../../sanitizer_common/sanitizer_posix.cc<br class=""> ../../sanitizer_common/sanitizer_posix_libcdep.cc<br class=""> ../../sanitizer_common/sanitizer_procmaps_common.cc<br class=""><br class="">Also, I think we should unconditionally include sanitizer_common_libcdep.cc<br class="">like this. (But the error below is unrelated.)<br class="">diff --git a/lib/tsan/go/buildgo.sh b/lib/tsan/go/buildgo.sh<br class="">index a7e12f1..8c89d8f 100755<br class="">--- a/lib/tsan/go/buildgo.sh<br class="">+++ b/lib/tsan/go/buildgo.sh<br class="">@@ -20,6 +20,7 @@ SRCS="<br class=""> ../rtl/tsan_sync.cc<br class=""> ../../sanitizer_common/sanitizer_allocator.cc<br class=""> ../../sanitizer_common/sanitizer_common.cc<br class="">+ ../../sanitizer_common/sanitizer_common_libcdep.cc<br class=""> ../../sanitizer_common/sanitizer_deadlock_detector2.cc<br class=""> ../../sanitizer_common/sanitizer_flag_parser.cc<br class=""> ../../sanitizer_common/sanitizer_flags.cc<br class=""><br class="">I got<br class=""><br class="">libRTSanitizerCommon.test.nolibc.x86_64.a(sanitizer_printf.cc.o): In<br class="">function `__sanitizer::SharedPrintfCode(bool, char const*,<br class="">__va_list_tag*)':<br class="">/export/gnu/import/git/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_printf.cc:281:<br class="">undefined reference to `__sanitizer::ShouldLogAfterPrintf()'<br class="">clang-3.8: error: linker command failed with exit code 1 (use -v to<br class="">see invocation)<br class="">projects/compiler-rt/lib/sanitizer_common/tests/CMakeFiles/Sanitizer-x86_64-Test-Nolibc.dir/build.make:59:<br class="">recipe for target<br class="">'projects/compiler-rt/lib/sanitizer_common/tests/CMakeFiles/Sanitizer-x86_64-Test-Nolibc'<br class="">failed<br class="">gmake[4]: ***<br class="">[projects/compiler-rt/lib/sanitizer_common/tests/CMakeFiles/Sanitizer-x86_64-Test-Nolibc]<br class="">Error 1<br class=""><br class=""><br class=""><br class="">--<br class="">H.J.<br class=""><br class=""><br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">H.J.</span></div></blockquote></div><br class=""></body></html>