<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks James! This is wonderful!<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 27, 2015, at 11:18 AM, James Molloy <<a href="mailto:james@jamesmolloy.co.uk" class="">james@jamesmolloy.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Initial import done in r251431.<div class=""><br class=""></div><div class="">Renato, you can now commit D14061, thanks!</div><div class=""><br class=""></div><div class="">James</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, 27 Oct 2015 at 18:15 James Molloy <<a href="mailto:james@jamesmolloy.co.uk" class="">james@jamesmolloy.co.uk</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">Hi Chris,<div class=""><br class=""></div><div class="">I agree with your logic, and will make the version change when I land it.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class=""><br class=""></div><div class="">James</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, 27 Oct 2015 at 16:58 Chris Bieneman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">beanz accepted this revision.<br class="">
beanz added a comment.<br class="">
This revision is now accepted and ready to land.<br class="">
<br class="">
LGTM. One comment below, more for posterity than anything else.<br class="">
<br class="">
<br class="">
================<br class="">
Comment at: CMakeLists.txt:2<br class="">
@@ +1,3 @@<br class="">
+cmake_minimum_required(VERSION 2.8.12.2)<br class="">
+<br class="">
+# The test-suite is designed to be built in release mode anyway and<br class="">
----------------<br class="">
jmolloy wrote:<br class="">
> My unscientific straw poll of LLVM users inside ARM says that 2.8.12.2 is still the minimum we can expect - Ubuntu 14.10 LTS still ships this, I'm afraid, and as it's the latest LTS I'm not sure it's old enough to deprecate.<br class="">
The minimum version is dictated per-project, there is no global expectation. There is more burden involved in raising a version, than creating a new project with a higher minimum requirement, which is why I asked that we consider moving this up (to avoid having to move it up later).<br class="">
<br class="">
We don't have any requirement or expectation that we will support the version of tools in an LTS Linux release. We have had this conversation numerous times, and it is not considered unreasonable that we might in the future request that Linux users behave like all the other users of LLVM and acquire their own copies of CMake (neither OS X nor Windows ship CMake or package managers). The reason LLVM and Clang haven't raised their minimum versions is that we haven't had compelling reasons to justify the change.<br class="">
<br class="">
I believe that starting a new build system free of version-based checks is compelling reason to start this new project with a higher minimum version. Ideally I would want this to require at least CMake 3.2 which has been out for 6 months or so. That said, my personal preference for trying to push forward our CMake version isn't motivation enough to argue about landing this patch.<br class="">
<br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="http://reviews.llvm.org/D14046" rel="noreferrer" target="_blank" class="">http://reviews.llvm.org/D14046</a><br class="">
<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></blockquote></div></div>
</div></blockquote></div><br class=""></div></body></html>