<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 22, 2015 at 10:26 PM, Saleem Abdulrasool via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: compnerd<br>
Date: Fri Oct 23 00:26:03 2015<br>
New Revision: 251094<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=251094&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=251094&view=rev</a><br>
Log:<br>
Support, IR: silence -Wunused-parameter<br>
<br>
If this is used outside of LLVM with -Werror, this would cause a failure.<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/IR/Metadata.h<br>
    llvm/trunk/include/llvm/IR/User.h<br>
    llvm/trunk/include/llvm/Support/CommandLine.h<br>
<br>
Modified: llvm/trunk/include/llvm/IR/Metadata.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Metadata.h?rev=251094&r1=251093&r2=251094&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/Metadata.h?rev=251094&r1=251093&r2=251094&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/IR/Metadata.h (original)<br>
+++ llvm/trunk/include/llvm/IR/Metadata.h Fri Oct 23 00:26:03 2015<br>
@@ -914,13 +914,13 @@ private:<br>
     N->recalculateHash();<br>
   }<br>
   template <class NodeTy><br>
-  static void dispatchRecalculateHash(NodeTy *N, std::false_type) {}<br>
+  static void dispatchRecalculateHash(NodeTy *, std::false_type) {}<br>
   template <class NodeTy><br>
   static void dispatchResetHash(NodeTy *N, std::true_type) {<br>
     N->setHash(0);<br>
   }<br>
   template <class NodeTy><br>
-  static void dispatchResetHash(NodeTy *N, std::false_type) {}<br>
+  static void dispatchResetHash(NodeTy *, std::false_type) {}<br>
<br>
 public:<br>
   typedef const MDOperand *op_iterator;<br>
<br>
Modified: llvm/trunk/include/llvm/IR/User.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/User.h?rev=251094&r1=251093&r2=251094&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/User.h?rev=251094&r1=251093&r2=251094&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/IR/User.h (original)<br>
+++ llvm/trunk/include/llvm/IR/User.h Fri Oct 23 00:26:03 2015<br>
@@ -65,7 +65,7 @@ protected:<br>
   /// This is used for subclasses which have a fixed number of operands.<br>
   void *operator new(size_t Size, unsigned Us, unsigned DescBytes);<br>
<br>
-  User(Type *ty, unsigned vty, Use *OpList, unsigned NumOps)<br>
+  User(Type *ty, unsigned vty, Use *, unsigned NumOps)<br>
       : Value(ty, vty) {<br>
     assert(NumOps < (1u << NumUserOperandsBits) && "Too many operands");<br>
     NumUserOperands = NumOps;<br></blockquote><div><br></div><div><div>I think it would be nicer to comment out the variable names instead of removing them.  It makes perusing the headers a little easier.<br></div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified: llvm/trunk/include/llvm/Support/CommandLine.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CommandLine.h?rev=251094&r1=251093&r2=251094&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/CommandLine.h?rev=251094&r1=251093&r2=251094&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Support/CommandLine.h (original)<br>
+++ llvm/trunk/include/llvm/Support/CommandLine.h Fri Oct 23 00:26:03 2015<br>
@@ -714,7 +714,7 @@ public:<br>
 //<br>
 class basic_parser_impl { // non-template implementation of basic_parser<t><br>
 public:<br>
-  basic_parser_impl(Option &O) {}<br>
+  basic_parser_impl(Option &) {}<br>
<br>
<br>
   enum ValueExpected getValueExpectedFlagDefault() const {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>