<div dir="rtl"><div dir="ltr">Reverted in r250924, thanks!</div><div dir="ltr"><br></div><div dir="ltr">Since llvm-config.h does not provide the HAVE_* defines, does it makes sense for FileSystem.h to include the code</div><div dir="ltr"><br></div><div dir="ltr"><div dir="ltr">#ifdef HAVE_SYS_STAT_H</div><div dir="ltr">#include <sys/stat.h></div><div dir="ltr">#endif</div><div><br></div><div>shouldn't this code go elsewhere? possibly in the code that needs it?<br></div><div><br></div></div></div><div class="gmail_extra"><div dir="ltr"><br><div class="gmail_quote">2015-10-21 21:34 GMT+03:00 Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">config.h is not an installed header, so this is not allowed. Only llvm-config.h is installed.</blockquote></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 21, 2015 at 11:28 AM, Yaron Keren via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: yrnkrn<br>
Date: Wed Oct 21 13:28:35 2015<br>
New Revision: 250923<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250923&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=250923&view=rev</a><br>
Log:<br>
Include llvm/Config/config.h in FileSystem.h as it depends upon HAVE_SYS_STAT_H which is defined (or not) in config.h.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Support/FileSystem.h<br>
<br>
Modified: llvm/trunk/include/llvm/Support/FileSystem.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=250923&r1=250922&r2=250923&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=250923&r1=250922&r2=250923&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Support/FileSystem.h (original)<br>
+++ llvm/trunk/include/llvm/Support/FileSystem.h Wed Oct 21 13:28:35 2015<br>
@@ -30,6 +30,7 @@<br>
 #include "llvm/ADT/IntrusiveRefCntPtr.h"<br>
 #include "llvm/ADT/SmallString.h"<br>
 #include "llvm/ADT/Twine.h"<br>
+#include "llvm/Config/config.h"<br>
 #include "llvm/Support/DataTypes.h"<br>
 #include "llvm/Support/ErrorHandling.h"<br>
 #include "llvm/Support/TimeValue.h"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></div></div>