<div dir="rtl"><div dir="ltr">The warning was <span style="font-size:12.8px">BitcodeReader.cpp(5543): warning C4065: switch statement contains 'default' but no 'case' labels. </span></div><div dir="ltr">The switch appears to be a placeholder, the comment above says:<br></div><div dir="ltr"><br></div><div dir="ltr">  // TODO: Read a record. This interface will be completed when ThinLTO<br></div><div dir="ltr"><div dir="ltr">  // importing is added so that it can be tested.</div><div dir="ltr"><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-10-21 22:49 GMT+03:00 David Blaikie via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div>On Wed, Oct 21, 2015 at 12:33 PM, Aaron Ballman via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Wed, Oct 21, 2015 at 3:25 PM, Teresa Johnson via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: tejohnson<br>
> Date: Wed Oct 21 14:25:14 2015<br>
> New Revision: 250929<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250929&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=250929&view=rev</a><br>
> Log:<br>
> Silence Visual C++ warning in function summary parsing code (NFC)<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp<br>
><br>
> Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=250929&r1=250928&r2=250929&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=250929&r1=250928&r2=250929&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)<br>
> +++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Wed Oct 21 14:25:14 2015<br>
> @@ -5538,6 +5538,7 @@ std::error_code FunctionIndexBitcodeRead<br>
>    // importing is added so that it can be tested.<br>
>    SmallVector<uint64_t, 64> Record;<br>
>    switch (Stream.readRecord(Entry.ID, Record)) {<br>
> +    case bitc::FS_CODE_COMBINED_ENTRY:<br>
>      default:<br>
>        return error("Invalid record");<br>
<br>
</span>What warning is this silencing? It seems like the correct approach is<br>
to remove the switch entirely.<br></blockquote><div><br></div></div></div><div>+1 - this looks like it should just be:<br><br>if (Stream.readRecord(...))<br>  return error(...);</div><span><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
~Aaron<br>
<div><div><br>
>    }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></span></div><br></div></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>