<div dir="ltr">Anyone else seeing fallout from this change for the go bindings tests? Not sure why I'm the only one, must be some remnant in my build tree, maybe, but not sure the best way to clear it out:<br><br><pre style="color:rgb(0,0,0)">/usr/local/google/home/blaikie/dev/llvm/build/clang/debug/split/notypes/nostandalone/./bin/llvm-go test <a href="http://llvm.org/llvm/bindings/go/llvm">llvm.org/llvm/bindings/go/llvm</a>
--
Exit Code: 1
Command Output (stdout):
--
FAIL <a href="http://llvm.org/llvm/bindings/go/llvm">llvm.org/llvm/bindings/go/llvm</a> [build failed]
--
Command Output (stderr):
--
# <a href="http://llvm.org/llvm/bindings/go/llvm
/tmp/go-build809812263/llvm.org/llvm/bindings/go/llvm/_test/_obj_test/DIBuilderBindings.cpp.o:/tmp/gopath218949839/src/llvm.org/llvm/bindings/go/llvm/DIBuilder">llvm.org/llvm/bindings/go/llvm
/tmp/go-build809812263/llvm.org/llvm/bindings/go/llvm/_test/_obj_test/DIBuilderBindings.cpp.o:/tmp/gopath218949839/src/llvm.org/llvm/bindings/go/llvm/DIBuilder</a>
Bindings.cpp:function LLVMDIBuilderCreateSubroutineType: error: undefined reference to 'llvm::DIBuilder::createSubroutineType(llvm::DITypeRefArray, unsigned in
t)'
clang-3.4: error: linker command failed with exit code 1 (use -v to see invocation)</pre></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 14, 2015 at 11:56 PM, Eric Christopher via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Thu Oct 15 01:56:10 2015<br>
New Revision: 250374<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250374&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=250374&view=rev</a><br>
Log:<br>
Remove DIFile from createSubroutineType.<br>
<br>
Patch by Amaury Sechet with a small modification by me.<br>
<br>
Modified:<br>
llvm/trunk/bindings/go/llvm/DIBuilderBindings.cpp<br>
llvm/trunk/include/llvm/IR/DIBuilder.h<br>
llvm/trunk/lib/IR/DIBuilder.cpp<br>
llvm/trunk/unittests/IR/IRBuilderTest.cpp<br>
llvm/trunk/unittests/Transforms/Utils/Cloning.cpp<br>
<br>
Modified: llvm/trunk/bindings/go/llvm/DIBuilderBindings.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/bindings/go/llvm/DIBuilderBindings.cpp?rev=250374&r1=250373&r2=250374&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/bindings/go/llvm/DIBuilderBindings.cpp?rev=250374&r1=250373&r2=250374&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/bindings/go/llvm/DIBuilderBindings.cpp (original)<br>
+++ llvm/trunk/bindings/go/llvm/DIBuilderBindings.cpp Thu Oct 15 01:56:10 2015<br>
@@ -128,8 +128,7 @@ LLVMDIBuilderCreateSubroutineType(LLVMDI<br>
LLVMMetadataRef ParameterTypes) {<br>
DIBuilder *D = unwrap(Dref);<br>
return wrap(<br>
- D->createSubroutineType(File ? unwrap<DIFile>(File) : nullptr,<br>
- DITypeRefArray(unwrap<MDTuple>(ParameterTypes))));<br>
+ D->createSubroutineType(DITypeRefArray(unwrap<MDTuple>(ParameterTypes))));<br>
}<br>
<br>
LLVMMetadataRef LLVMDIBuilderCreateStructType(<br>
<br>
Modified: llvm/trunk/include/llvm/IR/DIBuilder.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DIBuilder.h?rev=250374&r1=250373&r2=250374&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DIBuilder.h?rev=250374&r1=250373&r2=250374&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/IR/DIBuilder.h (original)<br>
+++ llvm/trunk/include/llvm/IR/DIBuilder.h Thu Oct 15 01:56:10 2015<br>
@@ -375,13 +375,11 @@ namespace llvm {<br>
DIType *UnderlyingType, StringRef UniqueIdentifier = "");<br>
<br>
/// Create subroutine type.<br>
- /// \param File File in which this subroutine is defined.<br>
/// \param ParameterTypes An array of subroutine parameter types. This<br>
/// includes return type at 0th index.<br>
/// \param Flags E.g.: LValueReference.<br>
/// These flags are used to emit dwarf attributes.<br>
- DISubroutineType *createSubroutineType(DIFile *File,<br>
- DITypeRefArray ParameterTypes,<br>
+ DISubroutineType *createSubroutineType(DITypeRefArray ParameterTypes,<br>
unsigned Flags = 0);<br>
<br>
/// Create an external type reference.<br>
@@ -702,7 +700,7 @@ namespace llvm {<br>
/// has a self-reference -- \a DIBuilder needs to track the array to<br>
/// resolve cycles.<br>
void replaceArrays(DICompositeType *&T, DINodeArray Elements,<br>
- DINodeArray TParems = DINodeArray());<br>
+ DINodeArray TParams = DINodeArray());<br>
<br>
/// Replace a temporary node.<br>
///<br>
<br>
Modified: llvm/trunk/lib/IR/DIBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=250374&r1=250373&r2=250374&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=250374&r1=250373&r2=250374&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/IR/DIBuilder.cpp (original)<br>
+++ llvm/trunk/lib/IR/DIBuilder.cpp Thu Oct 15 01:56:10 2015<br>
@@ -429,8 +429,7 @@ DICompositeType *DIBuilder::createUnionT<br>
return R;<br>
}<br>
<br>
-DISubroutineType *DIBuilder::createSubroutineType(DIFile *File,<br>
- DITypeRefArray ParameterTypes,<br>
+DISubroutineType *DIBuilder::createSubroutineType(DITypeRefArray ParameterTypes,<br>
unsigned Flags) {<br>
return DISubroutineType::get(VMContext, Flags, ParameterTypes);<br>
}<br>
<br>
Modified: llvm/trunk/unittests/IR/IRBuilderTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/IRBuilderTest.cpp?rev=250374&r1=250373&r2=250374&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/IRBuilderTest.cpp?rev=250374&r1=250373&r2=250374&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/IR/IRBuilderTest.cpp (original)<br>
+++ llvm/trunk/unittests/IR/IRBuilderTest.cpp Thu Oct 15 01:56:10 2015<br>
@@ -312,7 +312,7 @@ TEST_F(IRBuilderTest, DIBuilder) {<br>
auto File = DIB.createFile("F.CBL", "/");<br>
auto CU = DIB.createCompileUnit(dwarf::DW_LANG_Cobol74, "F.CBL", "/",<br>
"llvm-cobol74", true, "", 0);<br>
- auto Type = DIB.createSubroutineType(File, DIB.getOrCreateTypeArray(None));<br>
+ auto Type = DIB.createSubroutineType(DIB.getOrCreateTypeArray(None));<br>
DIB.createFunction(CU, "foo", "", File, 1, Type, false, true, 1, 0, true, F);<br>
AllocaInst *I = Builder.CreateAlloca(Builder.getInt8Ty());<br>
auto BarSP = DIB.createFunction(CU, "bar", "", File, 1, Type, false, true, 1,<br>
@@ -362,7 +362,7 @@ TEST_F(IRBuilderTest, DebugLoc) {<br>
auto File = DIB.createFile("tmp.cpp", "/");<br>
auto CU = DIB.createCompileUnit(dwarf::DW_LANG_C_plus_plus_11, "tmp.cpp", "/",<br>
"", true, "", 0);<br>
- auto SPType = DIB.createSubroutineType(File, DIB.getOrCreateTypeArray(None));<br>
+ auto SPType = DIB.createSubroutineType(DIB.getOrCreateTypeArray(None));<br>
auto SP =<br>
DIB.createFunction(CU, "foo", "foo", File, 1, SPType, false, true, 1);<br>
DebugLoc DL1 = DILocation::get(Ctx, 2, 0, SP);<br>
<br>
Modified: llvm/trunk/unittests/Transforms/Utils/Cloning.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Transforms/Utils/Cloning.cpp?rev=250374&r1=250373&r2=250374&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Transforms/Utils/Cloning.cpp?rev=250374&r1=250373&r2=250374&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/Transforms/Utils/Cloning.cpp (original)<br>
+++ llvm/trunk/unittests/Transforms/Utils/Cloning.cpp Thu Oct 15 01:56:10 2015<br>
@@ -231,7 +231,7 @@ protected:<br>
auto *File = DBuilder.createFile("filename.c", "/file/dir/");<br>
DITypeRefArray ParamTypes = DBuilder.getOrCreateTypeArray(None);<br>
DISubroutineType *FuncType =<br>
- DBuilder.createSubroutineType(File, ParamTypes);<br>
+ DBuilder.createSubroutineType(ParamTypes);<br>
auto *CU =<br>
DBuilder.createCompileUnit(dwarf::DW_LANG_C99, "filename.c",<br>
"/file/dir", "CloneFunc", false, "", 0);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>