<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 19, 2015 at 3:49 PM, Lang Hames via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: lhames<br>
Date: Mon Oct 19 17:49:18 2015<br>
New Revision: 250749<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250749&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=250749&view=rev</a><br>
Log:<br>
[Orc] Use '= default' for move constructor/assignment as per dblaikie's review.<br>
<br>
Thanks Dave!<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h<br>
<br>
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h?rev=250749&r1=250748&r2=250749&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h?rev=250749&r1=250748&r2=250749&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h (original)<br>
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/CompileOnDemandLayer.h Mon Oct 19 17:49:18 2015<br>
@@ -69,21 +69,12 @@ private:<br>
<br>
     LogicalModuleResources() {}<br>
<br>
-    LogicalModuleResources(LogicalModuleResources &&Other) {<br>
-      SourceModule = std::move(Other.SourceModule);<br>
-      StubsToClone = std::move(StubsToClone);<br>
-      StubsMgr = std::move(StubsMgr);<br>
-    }<br>
-<br>
     // Explicit move constructor to make MSVC happy.<br>
-    LogicalModuleResources& operator=(LogicalModuleResources &&Other) {<br>
-      SourceModule = std::move(Other.SourceModule);<br>
-      StubsToClone = std::move(StubsToClone);<br>
-      StubsMgr = std::move(StubsMgr);<br>
-      return *this;<br>
-    }<br>
+    LogicalModuleResources(LogicalModuleResources &&Other) = default;<br></blockquote><div><br></div><div>Ack, sorry - I just meant = default on the default (no args) ctor. I don't think = default works on the move ops in MSVC... :/</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
     // Explicit move assignment to make MSVC happy.<br>
+    LogicalModuleResources& operator=(LogicalModuleResources &&Other) = default;<br>
+<br>
     JITSymbol findSymbol(StringRef Name, bool ExportedSymbolsOnly) {<br>
       if (Name.endswith("$stub_ptr") && !ExportedSymbolsOnly) {<br>
         assert(!ExportedSymbolsOnly && "Stubs are never exported");<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>