<div dir="ltr">Hi Daniel,<div><br></div><div>I suspected something like that - RuntimeDyldMachO had similar problems back when we started running the checker tests. Thank you very much for verifying! I'll go in and fix them up today.</div><div><br></div><div>Cheers,</div><div>Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 19, 2015 at 5:48 AM, Daniel Sanders <span dir="ltr"><<a href="mailto:Daniel.Sanders@imgtec.com" target="_blank">Daniel.Sanders@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">I've skimmed through RuntimeDyldCOFFX86_64 and there's a few places where it neglects to account for differences between host endian and target endian. If you search for
'(uint' you'll find them. It looks like COFF needs to use writeBytesUnaligned() like RuntimeDyldELF.cpp does.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Hope that helps.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>]
<b>On Behalf Of </b>David Blaikie via llvm-commits<br>
<b>Sent:</b> 16 October 2015 22:50<br>
<b>To:</b> Lang Hames<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [llvm] r250376 - [RuntimeDyld] Drop the '.s' suffix off the COFF test case - the MIPS bot started<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Oct 15, 2015 at 12:16 AM, Lang Hames via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: lhames<br>
Date: Thu Oct 15 02:16:40 2015<br>
New Revision: 250376<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250376&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=250376&view=rev</a><br>
Log:<br>
[RuntimeDyld] Drop the '.s' suffix off the COFF test case - the MIPS bot started<br>
failing when the suffix was added.<br>
<br>
I assume the lack of a '.s' suffix means that the test case just wasn't running<br>
before,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Yep, only certain suffixes are actually run as tests, in llvm/test/lit.cfg:<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"># suffixes: A list of file extensions to treat as test files. This is overriden<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"># by individual lit.local.cfg files in the test subdirectories.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">config.suffixes = ['.ll', '.c', '.cxx', '.test', '.txt', '.s']<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">and it has never worked on MIPS. I'll investigate that tomorrow.<br>
<br>
<br>
Added:<br>
llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64<br>
- copied unchanged from r250371, llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s<br>
Removed:<br>
llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s<br>
<br>
Removed: llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s?rev=250375&view=auto" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s?rev=250375&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s (original)<br>
+++ llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/COFF_x86_64.s (removed)<br>
@@ -1,34 +0,0 @@<br>
-# RUN: llvm-mc -triple=x86_64-pc-win32 -filetype=obj -o %T/COFF_x86_64.o %s<br>
-# RUN: llvm-rtdyld -triple=x86_64-pc-win32 -verify -check=%s %/T/COFF_x86_64.o<br>
- .text<br>
- .def F;<br>
- .scl 2;<br>
- .type 32;<br>
- .endef<br>
- .globl __real400921f9f01b866e<br>
- .section .rdata,"dr",discard,__real400921f9f01b866e<br>
- .align 8<br>
-__real400921f9f01b866e:<br>
- .quad 4614256650576692846 # double 3.1415899999999999<br>
- .text<br>
- .globl F<br>
- .global inst1<br>
- .align 16, 0x90<br>
-F: # @F<br>
-.Ltmp0:<br>
-.seh_proc F<br>
-# BB#0: # %entry<br>
-.Ltmp1:<br>
- .seh_endprologue<br>
-# rtdyld-check: decode_operand(inst1, 4) = __real400921f9f01b866e - next_pc(inst1)<br>
-inst1:<br>
- movsd __real400921f9f01b866e(%rip), %xmm0 # xmm0 = mem[0],zero<br>
- retq<br>
-.Leh_func_end0:<br>
-.Ltmp2:<br>
- .seh_endproc<br>
-<br>
-# Make sure the JIT doesn't bail out on BSS sections.<br>
- .bss<br>
-bss_check:<br>
- .fill 8, 1, 0<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>