<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Oct 16, 2015, at 9:56 AM, Eric Christopher <<a href="mailto:echristo@gmail.com" class="">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Eh? Why?</div></div></blockquote><div><br class=""></div><div>The file forward-declares DebugLocStream and then uses the inner type (DebugLocStream::ListBuilder *) in an argument list. As noted in the commit message, clang complains about this when building with modules.</div><div><br class=""></div><div>I’m unsure whether this is supposed to work or if I was just working around a bug in clang. If this is indeed a clang bug, we should fix it instead.</div><div><br class=""></div><div>-- adrian</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class="">-eric</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, Oct 15, 2015 at 2:00 PM Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br class="">
Date: Thu Oct 15 15:58:55 2015<br class="">
New Revision: 250459<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=250459&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=250459&view=rev</a><br class="">
Log:<br class="">
Replace a forward declaration with an #include.<br class="">
When building with modules the forward-declared inner class<br class="">
DebugLocStream::ListBuilder causes clang to fall over.<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/CodeGen/AsmPrinter/DebugLocEntry.h<br class="">
<br class="">
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DebugLocEntry.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DebugLocEntry.h?rev=250459&r1=250458&r2=250459&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DebugLocEntry.h?rev=250459&r1=250458&r2=250459&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/CodeGen/AsmPrinter/DebugLocEntry.h (original)<br class="">
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DebugLocEntry.h Thu Oct 15 15:58:55 2015<br class="">
@@ -9,6 +9,8 @@<br class="">
<br class="">
#ifndef LLVM_LIB_CODEGEN_ASMPRINTER_DEBUGLOCENTRY_H<br class="">
#define LLVM_LIB_CODEGEN_ASMPRINTER_DEBUGLOCENTRY_H<br class="">
+<br class="">
+#include "DebugLocStream.h"<br class="">
#include "llvm/ADT/SmallString.h"<br class="">
#include "llvm/IR/Constants.h"<br class="">
#include "llvm/IR/DebugInfo.h"<br class="">
@@ -17,7 +19,6 @@<br class="">
<br class="">
namespace llvm {<br class="">
class AsmPrinter;<br class="">
-class DebugLocStream;<br class="">
<br class="">
/// \brief This struct describes location entries emitted in the .debug_loc<br class="">
/// section.<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></body></html>