<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Oct 16, 2015 at 2:01 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="">On Fri, Oct 16, 2015 at 1:57 PM, Joerg Sonnenberger via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On Fri, Oct 16, 2015 at 07:36:43PM +0000, Rui Ueyama via llvm-commits wrote:<br>
> ================<br>
> Comment at: ELF/OutputSections.cpp:233<br>
> @@ +232,3 @@<br>
> +  uint32_t H = 5381;<br>
> +  for (unsigned char C : Name)<br>
> +    H = (H << 5) + H + C;<br>
> ----------------<br>
> Remove unsigned.<br>
<br>
</span>That would change the semantic, wouldn't it?<br></blockquote><div><br></div></span><div>Because H is uint32_t, C will be promoted to uint32_t, no?</div></div></div></div></blockquote><div><br></div><div>Wait, it may change the semantics.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>I wanted this change for consistency with HashSysv which is defined above.</div><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
> ================<br>
> Comment at: ELF/OutputSections.h:263<br>
> @@ +262,3 @@<br>
> +  static const unsigned NBucketsEstimation[];<br>
> +  static const unsigned NBucketsEstimationCount;<br>
> +  std::vector<HashData> HashedSymbols;<br>
> ----------------<br>
> Remove this. You can use sizeof(Primes) / sizeof(Prime[0]).<br>
<br>
</span>Even better: array_lengthof.<br>
<div><div><br>
Joerg<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>