<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
This definitely needs to be split up into a series of smaller
patches to be reviewable. I strongly suggest starting small,
getting through one cycle of review, then posting a couple more and
recursing. Reading through the diff, I see a lot of points which
will need discussion/clarification.<br>
<br>
Also, a bit of background on what you're trying to accomplish is
required. A link to a private google doc is not sufficient.<br>
<br>
Philip<br>
<br>
<div class="moz-cite-prefix">On 10/09/2015 02:21 PM, Larisse Voufo
via llvm-commits wrote:<br>
</div>
<blockquote
cite="mid:048c8c53bd43e0e5f9fa45424ebef83b@localhost.localdomain"
type="cite">
<pre wrap="">lvoufo updated this revision to Diff 36992.
lvoufo added a comment.
Clang-formet'ed.
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D13606">http://reviews.llvm.org/D13606</a>
Files:
include/llvm/IR/GlobalVariable.h
include/llvm/IR/Instructions.h
lib/Analysis/BasicAliasAnalysis.cpp
lib/Analysis/Loads.cpp
lib/Analysis/MemoryDependenceAnalysis.cpp
lib/IR/Globals.cpp
lib/IR/Instructions.cpp
lib/Transforms/IPO/GlobalOpt.cpp
lib/Transforms/IPO/Inliner.cpp
lib/Transforms/InstCombine/InstCombineCalls.cpp
lib/Transforms/InstCombine/InstCombineInternal.h
lib/Transforms/InstCombine/InstructionCombining.cpp
lib/Transforms/Scalar/GVN.cpp
test/Transforms/LoadElim/global-local-vars.ll
test/Transforms/LoadElim/global-vars.ll
test/Transforms/LoadElim/local-vars.ll
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>
<a class="moz-txt-link-freetext" href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>