<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: arial,helvetica,sans-serif; font-size: 10pt; color: #000000'><br><br><hr id="zwchr"><blockquote id="DWT4954" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Igor Kudrin via llvm-commits" <llvm-commits@lists.llvm.org><br><b>To: </b>"Rui Ueyama" <ruiu@google.com><br><b>Cc: </b>"llvm-commits" <llvm-commits@lists.llvm.org>, reviews+D13501+public+cc48a9c32b74c6f4@reviews.llvm.org<br><b>Sent: </b>Friday, October 9, 2015 10:13:20 AM<br><b>Subject: </b>Re: [PATCH] D13501: [ELF2] Add -wrap switch<br><br>
<br>
<br>
<div class="moz-cite-prefix">On 09.10.2015 20:45, Rui Ueyama wrote:<br>
</div>
<blockquote cite="mid:CAJENXgsxt+OMQkJy4GufuuyiC1r84N-MQs9k3iNLi9gpOoK=Ug@mail.gmail.com">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Thu, Oct 8, 2015 at 9:33 PM, Igor
Kudrin <span dir="ltr"><<a href="mailto:ikudrin.dev@gmail.com" target="_blank">ikudrin.dev@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div><span class=""> <br>
<br>
<div>On 09.10.2015 4:08, Rui Ueyama wrote:<br>
</div>
<blockquote>
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Wed, Oct 7, 2015 at
10:55 PM, Igor Kudrin <span dir="ltr"><<a href="mailto:ikudrin.dev@gmail.com" target="_blank"></a><a class="moz-txt-link-abbreviated" href="mailto:ikudrin.dev@gmail.com" target="_blank">ikudrin.dev@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div> I've
added some examples to show the
differences between your patch and GNU
ld's behavior, see <a href="http://reviews.llvm.org/D13528" target="_blank"></a><a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D13528" target="_blank">http://reviews.llvm.org/D13528</a>.
For me, it's not just the different way to
implement the switch, but mostly change
its meaning.</div>
</blockquote>
<div><br>
</div>
<div>It is indeed different from GNU, but I
think our behavior makes sense and I don't
think that's a bad difference. LLD's symbol
handling is already pretty different in some
area, particularly how we handle archive
files and --start-group/--end-group. Just
like that, this is something we don't want
to aim the exact compatibility.</div>
</div>
</div>
</div>
</blockquote>
<br>
</span> Any unnecessary difference may lead to
unexpected problems for end users. According to this, I
don't feel like accepting your approach, which, compared
to ld's behavior, is different in almost all aspects I
can imagine, whereas my original patch follows ld's and
gold's conduct pretty well. Maybe it's better not
implement this switch at all.<br>
</div>
</blockquote>
<div><br>
</div>
<div>I'd agree. Maybe we want some implementation of --wrap
in future, but probably it's too early. We can do that
later after getting better idea what end users would say.</div>
</div>
</div>
</div>
</blockquote>
<br>
OK. Let's postpone it for a while.<br></blockquote><br>For the record, I'll want the --wrap feature eventually (we need it to support profiling tools on statically-linked binaries).<br><br> -Hal<br><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;">
<br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@lists.llvm.org<br>http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br></blockquote><br><br><br>-- <br><div><span name="x"></span>Hal Finkel<br>Assistant Computational Scientist<br>Leadership Computing Facility<br>Argonne National Laboratory<span name="x"></span><br></div></div></body></html>