<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 6, 2015 at 6:56 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Needed to remove the comdat-ness as well because of darwin. Got that in r249504.</div></blockquote><div><br></div><div>Thanks!<br><br>Moved it back to the Generic directory, since the generic/specific wasn't the issue at all - my mistake - and now that the comdat's fixed, tehre's no reason not to have it there, I think.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="HOEnZb"><font color="#888888"><div><br></div><div>-eric</div></font></span></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Tue, Oct 6, 2015 at 5:19 PM David Blaikie via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dblaikie<br>
Date: Tue Oct  6 19:17:31 2015<br>
New Revision: 249489<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=249489&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=249489&view=rev</a><br>
Log:<br>
Move test to X86-specific due to some IR invalid on other targets<br>
<br>
Added:<br>
    llvm/trunk/test/DebugInfo/X86/def-line.ll<br>
      - copied, changed from r249487, llvm/trunk/test/DebugInfo/Generic/def-line.ll<br>
Removed:<br>
    llvm/trunk/test/DebugInfo/Generic/def-line.ll<br>
<br>
Removed: llvm/trunk/test/DebugInfo/Generic/def-line.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Generic/def-line.ll?rev=249488&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Generic/def-line.ll?rev=249488&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/Generic/def-line.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/Generic/def-line.ll (removed)<br>
@@ -1,95 +0,0 @@<br>
-; REQUIRES: object-emission<br>
-<br>
-; RUN: %llc_dwarf < %s -filetype=obj | llvm-dwarfdump -debug-dump=info - | FileCheck %s<br>
-<br>
-; Given the following source, ensure that the decl_line/file is correctly<br>
-; emitted and omitted on definitions if it mismatches/matches the declaration<br>
-<br>
-; struct foo {<br>
-;   static void f1() {<br>
-;   }<br>
-;   static void f2();<br>
-;   static void f3();<br>
-; };<br>
-; void foo::f2() {<br>
-;   f1(); // just to ensure f1 is emitted<br>
-; }<br>
-; #line 1 "bar.cpp"<br>
-; void foo::f3() {<br>
-; }<br>
-<br>
-; Skip the declarations<br>
-; CHECK: DW_TAG_subprogram<br>
-; CHECK: DW_TAG_subprogram<br>
-; CHECK: DW_TAG_subprogram<br>
-<br>
-; CHECK: DW_TAG_subprogram<br>
-; CHECK-NOT: {{DW_TAG|NULL|DW_AT_decl_file}}<br>
-; CHECK:   DW_AT_decl_line {{.*}}7<br>
-; CHECK-NOT: {{DW_TAG|NULL|DW_AT_decl_file}}<br>
-; CHECK:   DW_AT_specification {{.*}}f2<br>
-; CHECK-NOT: {{DW_TAG|NULL|DW_AT_decl_file}}<br>
-<br>
-; CHECK: DW_TAG_subprogram<br>
-; CHECK-NOT: {{DW_TAG|NULL|DW_AT_decl_line|DW_AT_decl_file}}<br>
-; CHECK:   DW_AT_specification {{.*}}f1<br>
-<br>
-; CHECK: DW_TAG_subprogram<br>
-; CHECK-NOT: {{DW_TAG|NULL}}<br>
-; CHECK:   DW_AT_decl_file {{.*}}bar.cpp<br>
-; CHECK-NOT: {{DW_TAG|NULL}}<br>
-; CHECK:   DW_AT_decl_line {{.*}}1<br>
-; CHECK-NOT: {{DW_TAG|NULL}}<br>
-; CHECK:   DW_AT_specification {{.*}}f3<br>
-<br>
-$_ZN3foo2f1Ev = comdat any<br>
-<br>
-; Function Attrs: uwtable<br>
-define void @_ZN3foo2f2Ev() #0 align 2 {<br>
-entry:<br>
-  call void @_ZN3foo2f1Ev(), !dbg !19<br>
-  ret void, !dbg !20<br>
-}<br>
-<br>
-; Function Attrs: nounwind uwtable<br>
-define linkonce_odr void @_ZN3foo2f1Ev() #1 comdat align 2 {<br>
-entry:<br>
-  ret void, !dbg !21<br>
-}<br>
-<br>
-; Function Attrs: nounwind uwtable<br>
-define void @_ZN3foo2f3Ev() #1 align 2 {<br>
-entry:<br>
-  ret void, !dbg !22<br>
-}<br>
-<br>
-attributes #0 = { uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }<br>
-attributes #1 = { nounwind uwtable "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+sse,+sse2" "unsafe-fp-math"="false" "use-soft-float"="false" }<br>
-<br>
-!<a href="http://llvm.dbg.cu" rel="noreferrer" target="_blank">llvm.dbg.cu</a> = !{!0}<br>
-!llvm.module.flags = !{!16, !17}<br>
-!llvm.ident = !{!18}<br>
-<br>
-!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 3.8.0 (trunk 249440) (llvm/trunk 249465)", isOptimized: false, runtimeVersion: 0, emissionKind: 1, enums: !2, retainedTypes: !3, subprograms: !11)<br>
-!1 = !DIFile(filename: "def-line.cpp", directory: "/tmp/dbginfo")<br>
-!2 = !{}<br>
-!3 = !{!4}<br>
-!4 = !DICompositeType(tag: DW_TAG_structure_type, name: "foo", file: !1, line: 1, size: 8, align: 8, elements: !5, identifier: "_ZTS3foo")<br>
-!5 = !{!6, !9, !10}<br>
-!6 = !DISubprogram(name: "f1", linkageName: "_ZN3foo2f1Ev", scope: !"_ZTS3foo", file: !1, line: 2, type: !7, isLocal: false, isDefinition: false, scopeLine: 2, flags: DIFlagPrototyped, isOptimized: false)<br>
-!7 = !DISubroutineType(types: !8)<br>
-!8 = !{null}<br>
-!9 = !DISubprogram(name: "f2", linkageName: "_ZN3foo2f2Ev", scope: !"_ZTS3foo", file: !1, line: 4, type: !7, isLocal: false, isDefinition: false, scopeLine: 4, flags: DIFlagPrototyped, isOptimized: false)<br>
-!10 = !DISubprogram(name: "f3", linkageName: "_ZN3foo2f3Ev", scope: !"_ZTS3foo", file: !1, line: 5, type: !7, isLocal: false, isDefinition: false, scopeLine: 5, flags: DIFlagPrototyped, isOptimized: false)<br>
-!11 = !{!12, !13, !15}<br>
-!12 = distinct !DISubprogram(name: "f2", linkageName: "_ZN3foo2f2Ev", scope: !"_ZTS3foo", file: !1, line: 7, type: !7, isLocal: false, isDefinition: true, scopeLine: 7, flags: DIFlagPrototyped, isOptimized: false, function: void ()* @_ZN3foo2f2Ev, declaration: !9, variables: !2)<br>
-!13 = distinct !DISubprogram(name: "f3", linkageName: "_ZN3foo2f3Ev", scope: !"_ZTS3foo", file: !14, line: 1, type: !7, isLocal: false, isDefinition: true, scopeLine: 1, flags: DIFlagPrototyped, isOptimized: false, function: void ()* @_ZN3foo2f3Ev, declaration: !10, variables: !2)<br>
-!14 = !DIFile(filename: "bar.cpp", directory: "/tmp/dbginfo")<br>
-!15 = distinct !DISubprogram(name: "f1", linkageName: "_ZN3foo2f1Ev", scope: !"_ZTS3foo", file: !1, line: 2, type: !7, isLocal: false, isDefinition: true, scopeLine: 2, flags: DIFlagPrototyped, isOptimized: false, function: void ()* @_ZN3foo2f1Ev, declaration: !6, variables: !2)<br>
-!16 = !{i32 2, !"Dwarf Version", i32 4}<br>
-!17 = !{i32 2, !"Debug Info Version", i32 3}<br>
-!18 = !{!"clang version 3.8.0 (trunk 249440) (llvm/trunk 249465)"}<br>
-!19 = !DILocation(line: 8, column: 3, scope: !12)<br>
-!20 = !DILocation(line: 9, column: 1, scope: !12)<br>
-!21 = !DILocation(line: 3, column: 3, scope: !15)<br>
-!22 = !DILocation(line: 2, column: 1, scope: !13)<br>
<br>
Copied: llvm/trunk/test/DebugInfo/X86/def-line.ll (from r249487, llvm/trunk/test/DebugInfo/Generic/def-line.ll)<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/def-line.ll?p2=llvm/trunk/test/DebugInfo/X86/def-line.ll&p1=llvm/trunk/test/DebugInfo/Generic/def-line.ll&r1=249487&r2=249489&rev=249489&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/def-line.ll?p2=llvm/trunk/test/DebugInfo/X86/def-line.ll&p1=llvm/trunk/test/DebugInfo/Generic/def-line.ll&r1=249487&r2=249489&rev=249489&view=diff</a><br>
==============================================================================<br>
    (empty)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>