<p dir="ltr">Thanks. To be clear, I think that nothing using elf_rala should read the location. </p>
<div class="gmail_quote">On Oct 7, 2015 6:11 PM, "Davide Italiano via llvm-commits" <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: davide<br>
Date: Wed Oct  7 17:10:02 2015<br>
New Revision: 249627<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=249627&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=249627&view=rev</a><br>
Log:<br>
[ELF2/AArch64] _ABS* relocations don't read contents. Fix it.<br>
<br>
Spotted by: Rafael Espindola.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Target.cpp<br>
<br>
Modified: lld/trunk/ELF/Target.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=249627&r1=249626&r2=249627&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=249627&r1=249626&r2=249627&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/ELF/Target.cpp (original)<br>
+++ lld/trunk/ELF/Target.cpp Wed Oct  7 17:10:02 2015<br>
@@ -299,16 +299,16 @@ void AArch64TargetInfo::relocateOne(uint<br>
   case R_AARCH64_ABS16:<br>
     if (!isInt<16>(S + A))<br>
       error("Relocation R_AARCH64_ABS16 out of range");<br>
-    or16le(L, S + A);<br>
+    write16le(L, S + A);<br>
     break;<br>
   case R_AARCH64_ABS32:<br>
     if (!isInt<32>(S + A))<br>
       error("Relocation R_AARCH64_ABS32 out of range");<br>
-    or32le(L, S + A);<br>
+    write32le(L, S + A);<br>
     break;<br>
   case R_AARCH64_ABS64:<br>
     // No overflow check needed.<br>
-    or64le(L, S + A);<br>
+    write64le(L, S + A);<br>
     break;<br>
   case R_AARCH64_ADD_ABS_LO12_NC:<br>
     // No overflow check needed.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>