<div dir="ltr"><div>0) Yeah, using Phabricator would be nice...</div><div><br></div>1) Can you provide a log with link error you observe?<div><br></div><div>2)</div><div>@@ -632,6 +632,10 @@ class Configuration(object):<br></div><div><div>                 self.cxx.flags += ['-fsanitize=thread']</div><div>                 self.config.available_features.add('tsan')</div><div>                 self.config.available_features.add('sanitizer-new-delete')</div><div>+            elif san == 'SafeStack':</div><div>+                self.cxx.flags += ['-fsanitize=safe-stack']</div><div>+                self.config.available_features.add('safestack')</div><div>+                self.config.available_features.add('sanitizer-new-delete')</div><div>^^<br></div><div>This doesn't seem right - SafeStack doesn't provide new/delete replacement.</div><div>             else:<br></div><div>                 self.lit_config.fatal('unsupported value for '</div><div>                                       'use_sanitizer: {0}'.format(san))</div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 5, 2015 at 4:46 PM, Kostya Serebryany via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+folks who may be able to answer... <div>Next time, please use <a href="http://llvm.org/docs/Phabricator.html" target="_blank">http://llvm.org/docs/Phabricator.html</a>, at least for for changes around -fsanitize=*</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Mon, Oct 5, 2015 at 2:20 AM, Valérian Rousset via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">Hello all,<br>
<br>
Here is a trivial patch to allow LLVM to be build with SafeStack, via<br>
LLVM_USE_SANITIZER=SafeStack.<br>
<br>
It does compile without issue, but some tests fail, mainly due to profiling with<br>
instrumentation.<br>
It fails with `undefined reference to `__safestack_unsafe_stack_ptr'` because it<br>
has to link with the SafeStack runtime but it wasn't build. What is the best way<br>
to do this? Mark the tests as unsupported or did I missed something?<br>
<br>
Have a nice day.<br>
<span><font color="#888888">--<br>
tharvik<br>
</font></span><br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div>