<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 29, 2015 at 11:04 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On 09/30/2015 12:56 AM, David Blaikie wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Tue, Sep 29, 2015 at 3:12 PM, Tobias Grosser <<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On 09/29/2015 10:12 PM, David Blaikie wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Tue, Sep 29, 2015 at 12:54 PM, Tobias Grosser via llvm-commits <<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
<br>
Author: grosser<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Date: Tue Sep 29 14:52:09 2015<br>
New Revision: 248823<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=248823&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=248823&view=rev</a><br>
Log:<br>
Replace default destructors by {} destructors<br>
<br>
Hope this fixes the buildbots for now.<br>
<br>
<br>
</blockquote>
Oh, sorry about that. Didn't see those buildbot failures.<br>
</blockquote></blockquote>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
No worries. This was a rather quick fix, so it is not minimal as you<br>
noted below. However, I already was surprised that your original<br>
change caused compilation failures, but onlyon older gcc versions.<br>
In case you happen to understand the error message, would it make<br>
sense to move back to a fixed version of your change?<br>
</blockquote>
<br>
<br>
Do you have a link (or just copy/paste inline) to the buildbot failure? I<br>
didn't spot it in any of the emails I got.<br>
</blockquote>
<br></span>
I added it in one of my previous commits that tried to unbreak the bot:<br>
<br>
BlockGenerators.h:683:7: error: looser throw specifier for ‘virtual<br>
polly::RegionGenerator::~RegionGenerator()’<br>
BlockGenerators.h:164:11: error: overriding ‘virtual polly::BlockGenerator::~BlockGenerator() noexcept<br>
(true)`</blockquote><div><br></div><div>Ah, did this fail after 248765 or only before? I removed the derived dtor (since it was unnecessary) in an attempt to fix this error. Sorry, should've called that out in my commit message and in a follow up to r248764.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Oh, wait, was this the throws-spec problem? I /thought/ I fixed that by<br>
making the derived dtor '= default' too, but maybe that was insufficient?<br>
</blockquote>
<br></span>
I have no idea. I could not reproduce this issue locally. The builder run<br>
gcc-4.7.2 if that helps.<br>
<br>
Best,<br>
Tobias<br>
</blockquote></div><br></div></div>