<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">I chose the name and unit in order to be consistent with the existing mem_bytes sample type in the ‘compile’ suite’. It’s intended to measure any type of memory metric desired.<div class=""><br class=""></div><div class="">Luke<br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 24, 2015, at 6:15 PM, James Molloy <<a href="mailto:james@jamesmolloy.co.uk" class="">james@jamesmolloy.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi,<br class=""><br class="">I don't suppose the name could be more verbose? It's kinda unnecessarily terse. <br class=""><br class="">Also, what is this measuring? Peak heap usage? Is bytes the best unit? (Kb? Mb?)<br class=""><br class="">Cheers,<br class=""><br class="">James<br class=""><div class="gmail_quote"><div dir="ltr" class="">On Thu, 24 Sep 2015 at 18:02, Chris Matthews via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">LGTM.<br class="">
<br class="">
> On Sep 24, 2015, at 2:18 PM, Luke Larson <<a href="mailto:llarson@apple.com" target="_blank" class="">llarson@apple.com</a>> wrote:<br class="">
><br class="">
> This patch adds the mem_bytes sample type to the NT suite:<br class="">
><br class="">
> <lnt_nt_mem_bytes.patch><br class="">
><br class="">
> Please take a look and commit if everything looks good.<br class="">
><br class="">
> Luke<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></div></body></html>