<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">LGTM! Thank!<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 23, 2015, at 8:35 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi,<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">I haven’t found much time to work on LNT in the past few months and wanted to come back to finally<br class="">land my binary hash patch, but wanted to do a bit more testing on it. That’s when I realized that there<br class="">isn’t much documentation on how to develop LNT and particularly on how to best run the regression<br class="">tests. Therefore, I’ve started writing a very initial developer guide for LNT, which I’ve just uploaded for<br class="">review at<span class="Apple-converted-space"> </span><a href="http://reviews.llvm.org/D13101" style="color: purple; text-decoration: underline;" class="">http://reviews.llvm.org/D13101</a>.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">While writing these guidelines on how to run regression tests while developing LNT, similar to how everyone<br class="">runs regression tests when developing other LLVM sub-projects, I realized again that running the regression<br class="">tests leave temporary files in the source checkout. That has annoyed me quite a bit in the past, e.g. every<br class="">time I needed to run something like “git status” in there. The attached 2 patches should fix this.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">The first patch makes sure that no .pyc files get generated when running the regression tests.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">The second patch results in temporary files being created in a sub-directory called “test_run_tmp” of the current directory,<br class="">instead of scattered across the test source code directory. This makes it possible to run the tests out-of-source-tree.<br class="">Even when you do run the tests in the source tree, all the temporary files are in a separate directory, not<br class="">scattered across the test source directories.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Do these changes look fine to commit?<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Thanks,<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Kristof<o:p class=""></o:p></div></div><span id="cid:598C0379-6C9C-4060-8CBA-00F8BDB5DE2D@localhost"><0001-Don-t-generate-.pyc-files-when-running-tests.patch></span><span id="cid:D5121AA9-3E30-418C-8784-D30F1D1CDD45@localhost"><0002-Avoid-leaving-temporary-files-in-the-source-when-run.patch></span></div></blockquote></div><br class=""></div></body></html>