<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 17, 2015, at 5:18 PM, NAKAMURA Takumi via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Sep 18, 2015 at 8:44 AM Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">(Re-sending to the right list)<br class=""><br class="">NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com" target="_blank" class="">geek4civic@gmail.com</a>> writes:<br class="">> Author: chapuni<br class="">> Date: Wed Jun 17 23:08:20 2015<br class="">> New Revision: 239987<br class="">><br class="">> URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=239987&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=239987&view=rev</a><br class="">> Log:<br class="">> config.h.*: Rework r210144. Don't edit<span class="Apple-converted-space"> </span><a href="http://config.h.in/" rel="noreferrer" target="_blank" class="">config.h.in</a><span class="Apple-converted-space"> </span>manually.<br class="">><br class="">> - Generate #include in<span class="Apple-converted-space"> </span><a href="http://configure.ac/" rel="noreferrer" target="_blank" class="">configure.ac</a>.<br class="">> - Resurrect the copy of llvm-config.h.cmake into config.h.cmake.<br class=""><br class="">Sorry to bring up such an old thread, but *why* did you duplicate<br class="">everything from llvm-config.h.cmake into config.h.cmake? This just makes<br class="">it more error prone to try to update these, since they need to be<br class="">updated in sync. config.h #includes llvm-config.h anyway...<br class=""></blockquote><div class=""><br class=""></div><div class="">I dare to say again, "Don't edit<span class="Apple-converted-space"> </span><a href="http://config.h.in/" class="">config.h.in</a><span class="Apple-converted-space"> </span>manually."</div><div class="">As far as we maintain autoconf build,<span class="Apple-converted-space"> </span><a href="http://config.h.in/" class="">config.h.in</a><span class="Apple-converted-space"> </span>is generated by<span class="Apple-converted-space"> </span><a href="http://configure.ac/" class="">configure.ac</a>.<br class=""></div><div class=""><br class=""></div><div class="">I suppose we were working for config.h.cmake in sync to<span class="Apple-converted-space"> </span><a href="http://config.h.in/" class="">config.h.in</a>.</div><div class="">That said, config.h.cmake can easily diverge from<span class="Apple-converted-space"> </span><a href="http://config.h.in/" class="">config.h.in</a>.</div><div class=""><br class=""></div><div class="">And, I suppose llvm-config.h.* may be subset of config.h.*.</div></div></div></div></blockquote><div><br class=""></div><div>Since config.h.cmake *includes* llvm-config.h, why would we have a subset of config.h.make in llvm-config.h? </div><div><br class=""></div><div>I’d expect the intersection between config.h.make and llvm-config.h.make to be null, why shouldn’t it be?</div><div><br class=""></div><div>Thanks,</div><div><br class=""></div><div>— </div><div>Mehdi</div><div><br class=""></div><div><br class=""></div><div><br class=""></div><br class=""><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div class="">I intended r239987 was "trying to keep config.h.cmake in sync to<span class="Apple-converted-space"> </span><a href="http://config.h.in/" class="">config.h.in</a>" rather than "copying back from llvm-config.h.cmake into config.h.cmake".</div><div class=""><br class=""></div><div class="">I know this is hairy.</div></div></div></div></blockquote><blockquote type="cite" class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote"><div class=""><br class=""></div><div class=""><br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">><br class="">> Modified:<br class="">> llvm/trunk/autoconf/<a href="http://configure.ac/" rel="noreferrer" target="_blank" class="">configure.ac</a><br class="">> llvm/trunk/include/llvm/Config/config.h.cmake<br class="">> llvm/trunk/include/llvm/Config/<a href="http://config.h.in/" rel="noreferrer" target="_blank" class="">config.h.in</a><br class="">><br class="">> Modified: llvm/trunk/autoconf/<a href="http://configure.ac/" rel="noreferrer" target="_blank" class="">configure.ac</a><br class="">> URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/configure.ac?rev=239987&r1=239986&r2=239987&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/autoconf/configure.ac?rev=239987&r1=239986&r2=239987&view=diff</a><br class="">> ==============================================================================<br class="">><br class="">> --- llvm/trunk/autoconf/<a href="http://configure.ac/" rel="noreferrer" target="_blank" class="">configure.ac</a><span class="Apple-converted-space"> </span>(original)<br class="">> +++ llvm/trunk/autoconf/<a href="http://configure.ac/" rel="noreferrer" target="_blank" class="">configure.ac</a><span class="Apple-converted-space"> </span>Wed Jun 17 23:08:20 2015<br class="">> @@ -2172,7 +2172,10 @@ dnl contains the same list of files as A<br class="">> dnl files can be updated automatically when their *.in sources change.<br class="">> AC_CONFIG_HEADERS([include/llvm/Config/config.h include/llvm/Config/llvm-config.h])<br class="">> AH_TOP([#ifndef CONFIG_H<br class="">> -#define CONFIG_H])<br class="">> +#define CONFIG_H<br class="">> +<br class="">> +/* Exported configuration */<br class="">> +#include "llvm/Config/llvm-config.h"])<br class="">> AH_BOTTOM([#endif])<br class="">><br class="">> AC_CONFIG_FILES([include/llvm/Config/Targets.def])<br class="">><br class="">> Modified: llvm/trunk/include/llvm/Config/config.h.cmake<br class="">> URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/config.h.cmake?rev=239987&r1=239986&r2=239987&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/config.h.cmake?rev=239987&r1=239986&r2=239987&view=diff</a><br class="">> ==============================================================================<br class="">> --- llvm/trunk/include/llvm/Config/config.h.cmake (original)<br class="">> +++ llvm/trunk/include/llvm/Config/config.h.cmake Wed Jun 17 23:08:20 2015<br class="">> @@ -411,12 +411,103 @@<br class="">> /* Have host's ___chkstk_ms */<br class="">> #cmakedefine HAVE____CHKSTK_MS ${HAVE____CHKSTK_MS}<br class="">><br class="">> -/* Define if we link Polly to the tools */<br class="">> -#cmakedefine LINK_POLLY_INTO_TOOLS<br class="">> +/* Linker version detected at compile time. */<br class="">> +#undef HOST_LINK_VERSION<br class="">> +<br class="">> +/* Installation directory for binary executables */<br class="">> +#cmakedefine LLVM_BINDIR "${LLVM_BINDIR}"<br class="">> +<br class="">> +/* Time at which LLVM was configured */<br class="">> +#cmakedefine LLVM_CONFIGTIME "${LLVM_CONFIGTIME}"<br class="">> +<br class="">> +/* Installation directory for data files */<br class="">> +#cmakedefine LLVM_DATADIR "${LLVM_DATADIR}"<br class="">> +<br class="">> +/* Target triple LLVM will generate code for by default */<br class="">> +#cmakedefine LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}"<br class="">> +<br class="">> +/* Installation directory for documentation */<br class="">> +#cmakedefine LLVM_DOCSDIR "${LLVM_DOCSDIR}"<br class="">> +<br class="">> +/* Define if LLVM is built with asserts and checks that change the layout of<br class="">> + client-visible data structures. */<br class="">> +#cmakedefine LLVM_ENABLE_ABI_BREAKING_CHECKS<br class="">> +<br class="">> +/* Define if threads enabled */<br class="">> +#cmakedefine01 LLVM_ENABLE_THREADS<br class="">><br class="">> /* Define if zlib compression is available */<br class="">> #cmakedefine01 LLVM_ENABLE_ZLIB<br class="">><br class="">> +/* Installation directory for config files */<br class="">> +#cmakedefine LLVM_ETCDIR "${LLVM_ETCDIR}"<br class="">> +<br class="">> +/* Has gcc/MSVC atomic intrinsics */<br class="">> +#cmakedefine01 LLVM_HAS_ATOMICS<br class="">> +<br class="">> +/* Host triple LLVM will be executed on */<br class="">> +#cmakedefine LLVM_HOST_TRIPLE "${LLVM_HOST_TRIPLE}"<br class="">> +<br class="">> +/* Installation directory for include files */<br class="">> +#cmakedefine LLVM_INCLUDEDIR "${LLVM_INCLUDEDIR}"<br class="">> +<br class="">> +/* Installation directory for .info files */<br class="">> +#cmakedefine LLVM_INFODIR "${LLVM_INFODIR}"<br class="">> +<br class="">> +/* Installation directory for man pages */<br class="">> +#cmakedefine LLVM_MANDIR "${LLVM_MANDIR}"<br class="">> +<br class="">> +/* LLVM architecture name for the native architecture, if available */<br class="">> +#cmakedefine LLVM_NATIVE_ARCH ${LLVM_NATIVE_ARCH}<br class="">> +<br class="">> +/* LLVM name for the native AsmParser init function, if available */<br class="">> +#cmakedefine LLVM_NATIVE_ASMPARSER LLVMInitialize${LLVM_NATIVE_ARCH}AsmParser<br class="">> +<br class="">> +/* LLVM name for the native AsmPrinter init function, if available */<br class="">> +#cmakedefine LLVM_NATIVE_ASMPRINTER LLVMInitialize${LLVM_NATIVE_ARCH}AsmPrinter<br class="">> +<br class="">> +/* LLVM name for the native Disassembler init function, if available */<br class="">> +#cmakedefine LLVM_NATIVE_DISASSEMBLER LLVMInitialize${LLVM_NATIVE_ARCH}Disassembler<br class="">> +<br class="">> +/* LLVM name for the native Target init function, if available */<br class="">> +#cmakedefine LLVM_NATIVE_TARGET LLVMInitialize${LLVM_NATIVE_ARCH}Target<br class="">> +<br class="">> +/* LLVM name for the native TargetInfo init function, if available */<br class="">> +#cmakedefine LLVM_NATIVE_TARGETINFO LLVMInitialize${LLVM_NATIVE_ARCH}TargetInfo<br class="">> +<br class="">> +/* LLVM name for the native target MC init function, if available */<br class="">> +#cmakedefine LLVM_NATIVE_TARGETMC LLVMInitialize${LLVM_NATIVE_ARCH}TargetMC<br class="">> +<br class="">> +/* Define if this is Unixish platform */<br class="">> +#cmakedefine LLVM_ON_UNIX ${LLVM_ON_UNIX}<br class="">> +<br class="">> +/* Define if this is Win32ish platform */<br class="">> +#cmakedefine LLVM_ON_WIN32 ${LLVM_ON_WIN32}<br class="">> +<br class="">> +/* Installation prefix directory */<br class="">> +#cmakedefine LLVM_PREFIX "${LLVM_PREFIX}"<br class="">> +<br class="">> +/* Define if we have the Intel JIT API runtime support library */<br class="">> +#cmakedefine LLVM_USE_INTEL_JITEVENTS 1<br class="">> +<br class="">> +/* Define if we have the oprofile JIT-support library */<br class="">> +#cmakedefine LLVM_USE_OPROFILE 1<br class="">> +<br class="">> +/* Major version of the LLVM API */<br class="">> +#define LLVM_VERSION_MAJOR ${LLVM_VERSION_MAJOR}<br class="">> +<br class="">> +/* Minor version of the LLVM API */<br class="">> +#define LLVM_VERSION_MINOR ${LLVM_VERSION_MINOR}<br class="">> +<br class="">> +/* Patch version of the LLVM API */<br class="">> +#define LLVM_VERSION_PATCH ${LLVM_VERSION_PATCH}<br class="">> +<br class="">> +/* LLVM version string */<br class="">> +#define LLVM_VERSION_STRING "${PACKAGE_VERSION}"<br class="">> +<br class="">> +/* Define if we link Polly to the tools */<br class="">> +#cmakedefine LINK_POLLY_INTO_TOOLS<br class="">> +<br class="">> /* Define if the OS needs help to load dependent libraries for dlopen(). */<br class="">> #cmakedefine LTDL_DLOPEN_DEPLIBS ${LTDL_DLOPEN_DEPLIBS}<br class="">><br class="">><br class="">> Modified: llvm/trunk/include/llvm/Config/<a href="http://config.h.in/" rel="noreferrer" target="_blank" class="">config.h.in</a><br class="">> URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/config.h.in?rev=239987&r1=239986&r2=239987&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Config/config.h.in?rev=239987&r1=239986&r2=239987&view=diff</a><br class="">> ==============================================================================<br class="">> --- llvm/trunk/include/llvm/Config/<a href="http://config.h.in/" rel="noreferrer" target="_blank" class="">config.h.in</a><span class="Apple-converted-space"> </span>(original)<br class="">> +++ llvm/trunk/include/llvm/Config/<a href="http://config.h.in/" rel="noreferrer" target="_blank" class="">config.h.in</a><span class="Apple-converted-space"> </span>Wed Jun 17 23:08:20 2015<br class="">> @@ -3,6 +3,9 @@<br class="">> #ifndef CONFIG_H<br class="">> #define CONFIG_H<br class="">><br class="">> +/* Exported configuration */<br class="">> +#include "llvm/Config/llvm-config.h"<br class="">> +<br class="">> /* Bug report URL. */<br class="">> #undef BUG_REPORT_URL<br class="">><br class="">><br class="">><br class="">> _______________________________________________<br class="">> llvm-commits mailing list<br class="">><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">><span class="Apple-converted-space"> </span><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class=""></blockquote></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">llvm-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></span></div></blockquote></div><br class=""></body></html>