<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 10, 2015 at 9:49 AM, Hans Wennborg via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: hans<br>
Date: Thu Sep 10 11:49:58 2015<br>
New Revision: 247298<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=247298&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=247298&view=rev</a><br>
Log:<br>
Re-commit r247216: "Fix Clang-tidy misc-use-override warnings, other minor fixes"<br>
<br>
Except the changes that defined virtual destructors as =default, because that<br>
ran into problems with GCC 4.7 and overriding methods that weren't noexcept.<br></blockquote><div><br>FWIW, for anyone who wants to go through with those - we should just mark the user-defined derived dtors as noexcept (LLVM_NOEXCEPT) to address this (while making the base dtors = default, which implies noexcept).<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/include/llvm/CodeGen/MIRParser/MIRParser.h<br>
llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h<br>
llvm/trunk/include/llvm/Support/raw_ostream.h<br>
llvm/trunk/include/llvm/TableGen/Record.h<br>
llvm/trunk/lib/CodeGen/MIRPrintingPass.cpp<br>
llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h<br>
llvm/trunk/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp<br>
llvm/trunk/lib/Transforms/Instrumentation/SafeStack.cpp<br>
llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp<br>
<br>
Modified: llvm/trunk/include/llvm/CodeGen/MIRParser/MIRParser.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MIRParser/MIRParser.h?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/MIRParser/MIRParser.h?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/CodeGen/MIRParser/MIRParser.h (original)<br>
+++ llvm/trunk/include/llvm/CodeGen/MIRParser/MIRParser.h Thu Sep 10 11:49:58 2015<br>
@@ -1,4 +1,4 @@<br>
-//===- MIRParser.h - MIR serialization format parser ----------------------===//<br>
+//===- MIRParser.h - MIR serialization format parser ------------*- C++ -*-===//<br>
//<br>
// The LLVM Compiler Infrastructure<br>
//<br>
@@ -37,7 +37,7 @@ class MIRParser : public MachineFunction<br>
public:<br>
MIRParser(std::unique_ptr<MIRParserImpl> Impl);<br>
MIRParser(const MIRParser &) = delete;<br>
- ~MIRParser();<br>
+ ~MIRParser() override;<br>
<br>
/// Parse the optional LLVM IR module that's embedded in the MIR file.<br>
///<br>
@@ -78,4 +78,4 @@ createMIRParser(std::unique_ptr<MemoryBu<br>
<br>
} // end namespace llvm<br>
<br>
-#endif<br>
+#endif // LLVM_CODEGEN_MIRPARSER_MIRPARSER_H<br>
<br>
Modified: llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h (original)<br>
+++ llvm/trunk/include/llvm/ExecutionEngine/RuntimeDyld.h Thu Sep 10 11:49:58 2015<br>
@@ -69,7 +69,8 @@ public:<br>
virtual object::OwningBinary<object::ObjectFile><br>
getObjectForDebug(const object::ObjectFile &Obj) const = 0;<br>
<br>
- uint64_t getSectionLoadAddress(const object::SectionRef &Sec) const;<br>
+ uint64_t<br>
+ getSectionLoadAddress(const object::SectionRef &Sec) const override;<br>
<br>
protected:<br>
virtual void anchor();<br>
@@ -252,4 +253,4 @@ private:<br>
<br>
} // end namespace llvm<br>
<br>
-#endif<br>
+#endif // LLVM_EXECUTIONENGINE_RUNTIMEDYLD_H<br>
<br>
Modified: llvm/trunk/include/llvm/Support/raw_ostream.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/raw_ostream.h?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/raw_ostream.h?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Support/raw_ostream.h (original)<br>
+++ llvm/trunk/include/llvm/Support/raw_ostream.h Thu Sep 10 11:49:58 2015<br>
@@ -536,9 +536,9 @@ class buffer_ostream : public raw_svecto<br>
<br>
public:<br>
buffer_ostream(raw_ostream &OS) : raw_svector_ostream(Buffer), OS(OS) {}<br>
- ~buffer_ostream() { OS << str(); }<br>
+ ~buffer_ostream() override { OS << str(); }<br>
};<br>
<br>
} // end llvm namespace<br>
<br>
-#endif<br>
+#endif // LLVM_SUPPORT_RAW_OSTREAM_H<br>
<br>
Modified: llvm/trunk/include/llvm/TableGen/Record.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/TableGen/Record.h?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/TableGen/Record.h?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/TableGen/Record.h (original)<br>
+++ llvm/trunk/include/llvm/TableGen/Record.h Thu Sep 10 11:49:58 2015<br>
@@ -366,7 +366,7 @@ class TypedInit : public Init {<br>
<br>
protected:<br>
explicit TypedInit(InitKind K, RecTy *T) : Init(K), Ty(T) {}<br>
- ~TypedInit() {<br>
+ ~TypedInit() override {<br>
// If this is a DefInit we need to delete the RecordRecTy.<br>
if (getKind() == IK_DefInit)<br>
delete Ty;<br>
@@ -1587,6 +1587,6 @@ Init *QualifyName(Record &CurRec, MultiC<br>
Init *QualifyName(Record &CurRec, MultiClass *CurMultiClass,<br>
const std::string &Name, const std::string &Scoper);<br>
<br>
-} // End llvm namespace<br>
+} // end llvm namespace<br>
<br>
-#endif<br>
+#endif // LLVM_TABLEGEN_RECORD_H<br>
<br>
Modified: llvm/trunk/lib/CodeGen/MIRPrintingPass.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MIRPrintingPass.cpp?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MIRPrintingPass.cpp?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/MIRPrintingPass.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/MIRPrintingPass.cpp Thu Sep 10 11:49:58 2015<br>
@@ -40,7 +40,7 @@ struct MIRPrintingPass : public MachineF<br>
MachineFunctionPass::getAnalysisUsage(AU);<br>
}<br>
<br>
- virtual bool runOnMachineFunction(MachineFunction &MF) override {<br>
+ bool runOnMachineFunction(MachineFunction &MF) override {<br>
std::string Str;<br>
raw_string_ostream StrOS(Str);<br>
printMIR(StrOS, MF);<br>
@@ -48,7 +48,7 @@ struct MIRPrintingPass : public MachineF<br>
return false;<br>
}<br>
<br>
- virtual bool doFinalization(Module &M) override {<br>
+ bool doFinalization(Module &M) override {<br>
printMIR(OS, M);<br>
OS << MachineFunctions;<br>
return false;<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/MCJIT/MCJIT.h Thu Sep 10 11:49:58 2015<br>
@@ -223,12 +223,13 @@ public:<br>
/// FindFunctionNamed - Search all of the active modules to find the function that<br>
/// defines FnName. This is very slow operation and shouldn't be used for<br>
/// general code.<br>
- virtual Function *FindFunctionNamed(const char *FnName) override;<br>
+ Function *FindFunctionNamed(const char *FnName) override;<br>
<br>
- /// FindGlobalVariableNamed - Search all of the active modules to find the global variable<br>
- /// that defines Name. This is very slow operation and shouldn't be used for<br>
- /// general code.<br>
- virtual GlobalVariable *FindGlobalVariableNamed(const char *Name, bool AllowInternal = false) override;<br>
+ /// FindGlobalVariableNamed - Search all of the active modules to find the<br>
+ /// global variable that defines Name. This is very slow operation and<br>
+ /// shouldn't be used for general code.<br>
+ GlobalVariable *FindGlobalVariableNamed(const char *Name,<br>
+ bool AllowInternal = false) override;<br>
<br>
/// Sets the object manager that MCJIT should use to avoid compilation.<br>
void setObjectCache(ObjectCache *manager) override;<br>
@@ -335,6 +336,6 @@ protected:<br>
bool CheckFunctionsOnly);<br>
};<br>
<br>
-} // End llvm namespace<br>
+} // end llvm namespace<br>
<br>
-#endif<br>
+#endif // LLVM_LIB_EXECUTIONENGINE_MCJIT_MCJIT_H<br>
<br>
Modified: llvm/trunk/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmInstrumentation.cpp Thu Sep 10 11:49:58 2015<br>
@@ -185,14 +185,14 @@ public:<br>
X86AddressSanitizer(const MCSubtargetInfo &STI)<br>
: X86AsmInstrumentation(STI), RepPrefix(false), OrigSPOffset(0) {}<br>
<br>
- virtual ~X86AddressSanitizer() {}<br>
+ ~X86AddressSanitizer() override {}<br>
<br>
// X86AsmInstrumentation implementation:<br>
- virtual void InstrumentAndEmitInstruction(const MCInst &Inst,<br>
- OperandVector &Operands,<br>
- MCContext &Ctx,<br>
- const MCInstrInfo &MII,<br>
- MCStreamer &Out) override {<br>
+ void InstrumentAndEmitInstruction(const MCInst &Inst,<br>
+ OperandVector &Operands,<br>
+ MCContext &Ctx,<br>
+ const MCInstrInfo &MII,<br>
+ MCStreamer &Out) override {<br>
InstrumentMOVS(Inst, Operands, Ctx, MII, Out);<br>
if (RepPrefix)<br>
EmitInstruction(Out, MCInstBuilder(X86::REP_PREFIX));<br>
@@ -506,7 +506,7 @@ public:<br>
X86AddressSanitizer32(const MCSubtargetInfo &STI)<br>
: X86AddressSanitizer(STI) {}<br>
<br>
- virtual ~X86AddressSanitizer32() {}<br>
+ ~X86AddressSanitizer32() override {}<br>
<br>
unsigned GetFrameReg(const MCContext &Ctx, MCStreamer &Out) {<br>
unsigned FrameReg = GetFrameRegGeneric(Ctx, Out);<br>
@@ -535,9 +535,9 @@ public:<br>
OrigSPOffset += 4;<br>
}<br>
<br>
- virtual void InstrumentMemOperandPrologue(const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override {<br>
+ void InstrumentMemOperandPrologue(const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override {<br>
unsigned LocalFrameReg = RegCtx.ChooseFrameReg(MVT::i32);<br>
assert(LocalFrameReg != X86::NoRegister);<br>
<br>
@@ -565,9 +565,9 @@ public:<br>
StoreFlags(Out);<br>
}<br>
<br>
- virtual void InstrumentMemOperandEpilogue(const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override {<br>
+ void InstrumentMemOperandEpilogue(const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override {<br>
unsigned LocalFrameReg = RegCtx.ChooseFrameReg(MVT::i32);<br>
assert(LocalFrameReg != X86::NoRegister);<br>
<br>
@@ -586,18 +586,18 @@ public:<br>
}<br>
}<br>
<br>
- virtual void InstrumentMemOperandSmall(X86Operand &Op, unsigned AccessSize,<br>
- bool IsWrite,<br>
- const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override;<br>
- virtual void InstrumentMemOperandLarge(X86Operand &Op, unsigned AccessSize,<br>
- bool IsWrite,<br>
- const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override;<br>
- virtual void InstrumentMOVSImpl(unsigned AccessSize, MCContext &Ctx,<br>
- MCStreamer &Out) override;<br>
+ void InstrumentMemOperandSmall(X86Operand &Op, unsigned AccessSize,<br>
+ bool IsWrite,<br>
+ const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override;<br>
+ void InstrumentMemOperandLarge(X86Operand &Op, unsigned AccessSize,<br>
+ bool IsWrite,<br>
+ const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override;<br>
+ void InstrumentMOVSImpl(unsigned AccessSize, MCContext &Ctx,<br>
+ MCStreamer &Out) override;<br>
<br>
private:<br>
void EmitCallAsanReport(unsigned AccessSize, bool IsWrite, MCContext &Ctx,<br>
@@ -763,7 +763,7 @@ public:<br>
X86AddressSanitizer64(const MCSubtargetInfo &STI)<br>
: X86AddressSanitizer(STI) {}<br>
<br>
- virtual ~X86AddressSanitizer64() {}<br>
+ ~X86AddressSanitizer64() override {}<br>
<br>
unsigned GetFrameReg(const MCContext &Ctx, MCStreamer &Out) {<br>
unsigned FrameReg = GetFrameRegGeneric(Ctx, Out);<br>
@@ -792,9 +792,9 @@ public:<br>
OrigSPOffset += 8;<br>
}<br>
<br>
- virtual void InstrumentMemOperandPrologue(const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override {<br>
+ void InstrumentMemOperandPrologue(const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override {<br>
unsigned LocalFrameReg = RegCtx.ChooseFrameReg(MVT::i64);<br>
assert(LocalFrameReg != X86::NoRegister);<br>
<br>
@@ -823,9 +823,9 @@ public:<br>
StoreFlags(Out);<br>
}<br>
<br>
- virtual void InstrumentMemOperandEpilogue(const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override {<br>
+ void InstrumentMemOperandEpilogue(const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override {<br>
unsigned LocalFrameReg = RegCtx.ChooseFrameReg(MVT::i64);<br>
assert(LocalFrameReg != X86::NoRegister);<br>
<br>
@@ -845,18 +845,18 @@ public:<br>
}<br>
}<br>
<br>
- virtual void InstrumentMemOperandSmall(X86Operand &Op, unsigned AccessSize,<br>
- bool IsWrite,<br>
- const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override;<br>
- virtual void InstrumentMemOperandLarge(X86Operand &Op, unsigned AccessSize,<br>
- bool IsWrite,<br>
- const RegisterContext &RegCtx,<br>
- MCContext &Ctx,<br>
- MCStreamer &Out) override;<br>
- virtual void InstrumentMOVSImpl(unsigned AccessSize, MCContext &Ctx,<br>
- MCStreamer &Out) override;<br>
+ void InstrumentMemOperandSmall(X86Operand &Op, unsigned AccessSize,<br>
+ bool IsWrite,<br>
+ const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override;<br>
+ void InstrumentMemOperandLarge(X86Operand &Op, unsigned AccessSize,<br>
+ bool IsWrite,<br>
+ const RegisterContext &RegCtx,<br>
+ MCContext &Ctx,<br>
+ MCStreamer &Out) override;<br>
+ void InstrumentMOVSImpl(unsigned AccessSize, MCContext &Ctx,<br>
+ MCStreamer &Out) override;<br>
<br>
private:<br>
void EmitAdjustRSP(MCContext &Ctx, MCStreamer &Out, long Offset) {<br>
@@ -1080,4 +1080,4 @@ CreateX86AsmInstrumentation(const MCTarg<br>
return new X86AsmInstrumentation(STI);<br>
}<br>
<br>
-} // End llvm namespace<br>
+} // end llvm namespace<br>
<br>
Modified: llvm/trunk/lib/Transforms/Instrumentation/SafeStack.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/SafeStack.cpp?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/SafeStack.cpp?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Instrumentation/SafeStack.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Instrumentation/SafeStack.cpp Thu Sep 10 11:49:58 2015<br>
@@ -220,11 +220,11 @@ public:<br>
initializeSafeStackPass(*PassRegistry::getPassRegistry());<br>
}<br>
<br>
- virtual void getAnalysisUsage(AnalysisUsage &AU) const {<br>
+ void getAnalysisUsage(AnalysisUsage &AU) const override {<br>
AU.addRequired<AAResultsWrapperPass>();<br>
}<br>
<br>
- virtual bool doInitialization(Module &M) {<br>
+ bool doInitialization(Module &M) override {<br>
DL = &M.getDataLayout();<br>
<br>
StackPtrTy = Type::getInt8PtrTy(M.getContext());<br>
@@ -235,8 +235,7 @@ public:<br>
return false;<br>
}<br>
<br>
- bool runOnFunction(Function &F);<br>
-<br>
+ bool runOnFunction(Function &F) override;<br>
}; // class SafeStack<br>
<br>
Constant *SafeStack::getOrCreateUnsafeStackPtr(Module &M) {<br>
<br>
Modified: llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp?rev=247298&r1=247297&r2=247298&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp?rev=247298&r1=247297&r2=247298&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/InstrInfoEmitter.cpp Thu Sep 10 11:49:58 2015<br>
@@ -1,4 +1,4 @@<br>
-//===- InstrInfoEmitter.cpp - Generate a Instruction Set Desc. ------------===//<br>
+//===- InstrInfoEmitter.cpp - Generate a Instruction Set Desc. --*- C++ -*-===//<br>
//<br>
// The LLVM Compiler Infrastructure<br>
//<br>
@@ -12,7 +12,6 @@<br>
//<br>
//===----------------------------------------------------------------------===//<br>
<br>
-<br>
#include "CodeGenDAGPatterns.h"<br>
#include "CodeGenSchedule.h"<br>
#include "CodeGenTarget.h"<br>
@@ -26,6 +25,7 @@<br>
#include <cstdio><br>
#include <map><br>
#include <vector><br>
+<br>
using namespace llvm;<br>
<br>
namespace {<br>
@@ -70,7 +70,7 @@ private:<br>
void EmitOperandInfo(raw_ostream &OS, OperandInfoMapTy &OperandInfoIDs);<br>
std::vector<std::string> GetOperandInfo(const CodeGenInstruction &Inst);<br>
};<br>
-} // End anonymous namespace<br>
+} // end anonymous namespace<br>
<br>
static void PrintDefList(const std::vector<Record*> &Uses,<br>
unsigned Num, raw_ostream &OS) {<br>
@@ -190,7 +190,6 @@ void InstrInfoEmitter::EmitOperandInfo(r<br>
}<br>
}<br>
<br>
-<br>
/// Initialize data structures for generating operand name mappings.<br>
///<br>
/// \param Operands [out] A map used to generate the OpName enum with operand<br>
@@ -257,9 +256,9 @@ void InstrInfoEmitter::emitOperandNameMa<br>
<br>
OS << "OPERAND_LAST";<br>
OS << "\n};\n";<br>
- OS << "} // End namespace OpName\n";<br>
- OS << "} // End namespace " << Namespace << "\n";<br>
- OS << "} // End namespace llvm\n";<br>
+ OS << "} // end namespace OpName\n";<br>
+ OS << "} // end namespace " << Namespace << "\n";<br>
+ OS << "} // end namespace llvm\n";<br>
OS << "#endif //GET_INSTRINFO_OPERAND_ENUM\n";<br>
<br>
OS << "#ifdef GET_INSTRINFO_NAMED_OPS\n";<br>
@@ -298,8 +297,8 @@ void InstrInfoEmitter::emitOperandNameMa<br>
OS << " return -1;\n";<br>
}<br>
OS << "}\n";<br>
- OS << "} // End namespace " << Namespace << "\n";<br>
- OS << "} // End namespace llvm\n";<br>
+ OS << "} // end namespace " << Namespace << "\n";<br>
+ OS << "} // end namespace llvm\n";<br>
OS << "#endif //GET_INSTRINFO_NAMED_OPS\n";<br>
<br>
}<br>
@@ -328,9 +327,9 @@ void InstrInfoEmitter::emitOperandTypesE<br>
}<br>
<br>
OS << " OPERAND_TYPE_LIST_END" << "\n};\n";<br>
- OS << "} // End namespace OpTypes\n";<br>
- OS << "} // End namespace " << Namespace << "\n";<br>
- OS << "} // End namespace llvm\n";<br>
+ OS << "} // end namespace OpTypes\n";<br>
+ OS << "} // end namespace " << Namespace << "\n";<br>
+ OS << "} // end namespace llvm\n";<br>
OS << "#endif // GET_INSTRINFO_OPERAND_TYPES_ENUM\n";<br>
}<br>
<br>
@@ -419,7 +418,7 @@ void InstrInfoEmitter::run(raw_ostream &<br>
<< TargetName << "InstrNameIndices, " << TargetName << "InstrNameData, "<br>
<< NumberedInstructions.size() << ");\n}\n\n";<br>
<br>
- OS << "} // End llvm namespace \n";<br>
+ OS << "} // end llvm namespace \n";<br>
<br>
OS << "#endif // GET_INSTRINFO_MC_DESC\n\n";<br>
<br>
@@ -432,9 +431,9 @@ void InstrInfoEmitter::run(raw_ostream &<br>
OS << "struct " << ClassName << " : public TargetInstrInfo {\n"<br>
<< " explicit " << ClassName<br>
<< "(int CFSetupOpcode = -1, int CFDestroyOpcode = -1);\n"<br>
- << " virtual ~" << ClassName << "();\n"<br>
+ << " ~" << ClassName << "() override {}\n"<br>
<< "};\n";<br>
- OS << "} // End llvm namespace \n";<br>
+ OS << "} // end llvm namespace \n";<br>
<br>
OS << "#endif // GET_INSTRINFO_HEADER\n\n";<br>
<br>
@@ -450,9 +449,8 @@ void InstrInfoEmitter::run(raw_ostream &<br>
<< " : TargetInstrInfo(CFSetupOpcode, CFDestroyOpcode) {\n"<br>
<< " InitMCInstrInfo(" << TargetName << "Insts, " << TargetName<br>
<< "InstrNameIndices, " << TargetName << "InstrNameData, "<br>
- << NumberedInstructions.size() << ");\n}\n"<br>
- << ClassName << "::~" << ClassName << "() {}\n";<br>
- OS << "} // End llvm namespace \n";<br>
+ << NumberedInstructions.size() << ");\n}\n";<br>
+ OS << "} // end llvm namespace \n";<br>
<br>
OS << "#endif // GET_INSTRINFO_CTOR_DTOR\n\n";<br>
<br>
@@ -596,9 +594,9 @@ void InstrInfoEmitter::emitEnums(raw_ost<br>
OS << " " << Class.Name << "\t= " << Num++ << ",\n";<br>
OS << " SCHED_LIST_END = " << SchedModels.numInstrSchedClasses() << "\n";<br>
OS << " };\n";<br>
- OS << "} // End Sched namespace\n";<br>
- OS << "} // End " << Namespace << " namespace\n";<br>
- OS << "} // End llvm namespace \n";<br>
+ OS << "} // end Sched namespace\n";<br>
+ OS << "} // end " << Namespace << " namespace\n";<br>
+ OS << "} // end llvm namespace \n";<br>
<br>
OS << "#endif // GET_INSTRINFO_ENUM\n\n";<br>
}<br>
@@ -610,4 +608,4 @@ void EmitInstrInfo(RecordKeeper &RK, raw<br>
EmitMapTable(RK, OS);<br>
}<br>
<br>
-} // End llvm namespace<br>
+} // end llvm namespace<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>