<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 10, 2015 at 1:29 AM, Chandler Carruth via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Thu Sep 10 03:29:30 2015<br>
New Revision: 247252<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=247252&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=247252&view=rev</a><br>
Log:<br>
[Support] Fix the always_inline attribute macro to not include the<br>
'inline' specifier. That specifier may or may not be valid for a given<br>
function,</blockquote><div><br>When is it not valid for a given function?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> or it may be required for correct linkage even when the<br>
compiler doesn't support the always_inline attribute.<br></blockquote><div><br>Not sure I follow this case - the macro doesn't redundantly specify the inline keyword (& even then, specifying it twice is valid but redundant, maybe?), so it just means users of the macro don't need to/shouldn't /also/ explicitly use the inline keyword on the same declaration.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/include/llvm/Support/Compiler.h<br>
<br>
Modified: llvm/trunk/include/llvm/Support/Compiler.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Compiler.h?rev=247252&r1=247251&r2=247252&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Compiler.h?rev=247252&r1=247251&r2=247252&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Support/Compiler.h (original)<br>
+++ llvm/trunk/include/llvm/Support/Compiler.h Thu Sep 10 03:29:30 2015<br>
@@ -189,7 +189,7 @@<br>
 /// 3.4 supported this but is buggy in various cases and produces unimplemented<br>
 /// errors, just use it in GCC 4.0 and later.<br>
 #if __has_attribute(always_inline) || LLVM_GNUC_PREREQ(4, 0, 0)<br>
-#define LLVM_ATTRIBUTE_ALWAYS_INLINE inline __attribute__((always_inline))<br>
+#define LLVM_ATTRIBUTE_ALWAYS_INLINE __attribute__((always_inline))<br>
 #elif defined(_MSC_VER)<br>
 #define LLVM_ATTRIBUTE_ALWAYS_INLINE __forceinline<br>
 #else<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>