<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 10, 2015 at 4:46 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Good question. It is the first time I hit it, so I really don't have an opinion.<br>
<br>
It looks like this one is -Wno-enum-compare. If we are disabling it we<br>
should probably do it for all of llvm.<br></blockquote><div><br>Yeah, that's what I was implying - I'm not too fussed, but like to raise the question whenever we suppress a warning that doesn't look like a bug.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Cheers,<br>
Rafael<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On 10 September 2015 at 19:24, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
><br>
> On Thu, Sep 10, 2015 at 1:02 PM, Rafael Espindola via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: rafael<br>
>> Date: Thu Sep 10 15:02:22 2015<br>
>> New Revision: 247330<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=247330&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=247330&view=rev</a><br>
>> Log:<br>
>> Fix a warning when building with gcc.<br>
>><br>
>> It was<br>
>><br>
>> /Writer.cpp:119:45: warning: enumeral and non-enumeral type in conditional<br>
>> expression<br>
><br>
><br>
> Any evidence that this catches bugs? Or should we just disable it?<br>
><br>
>><br>
>><br>
>> Modified:<br>
>>     lld/trunk/ELF/Writer.cpp<br>
>><br>
>> Modified: lld/trunk/ELF/Writer.cpp<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=247330&r1=247329&r2=247330&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=247330&r1=247329&r2=247330&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- lld/trunk/ELF/Writer.cpp (original)<br>
>> +++ lld/trunk/ELF/Writer.cpp Thu Sep 10 15:02:22 2015<br>
>> @@ -116,7 +116,7 @@ public:<br>
>>    typedef typename OutputSectionBase<Is64Bits>::uintX_t uintX_t;<br>
>>    StringTableSection(bool Dynamic)<br>
>>        : OutputSectionBase<Is64Bits>(Dynamic ? ".dynstr" : ".strtab",<br>
>> SHT_STRTAB,<br>
>> -                                    Dynamic ? SHF_ALLOC : 0) {<br>
>> +                                    Dynamic ? (uintX_t)SHF_ALLOC : 0) {<br>
>>      this->Header.sh_addralign = 1;<br>
>>    }<br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>