<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 4, 2015 at 5:46 PM, Davide Italiano via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Fri, Sep 4, 2015 at 5:36 PM, Michael J. Spencer via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: mspencer<br>
> Date: Fri Sep  4 19:36:03 2015<br>
> New Revision: 246902<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246902&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246902&view=rev</a><br>
> Log:<br>
> [elf2] Add 32S and 64 relocations (needed for musl).<br>
><br>
> It wasn't obvious what the assembly was to generate these relocations, so I did the test with yaml.<br>
><br>
<br>
</span>It is actually obvious.<br>
Example 32S:<br>
<br>
.text<br>
blah:<br>
  movl $blah, %rdx<br></blockquote><div><br></div><div>Wouldn't this generate R_X86_64_32 instead?</div><div><br></div><div>-- Sean Silva</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Let's try to not have two different methods of testing -- it's gonna<br>
lead to headaches. I'm biased because I prefer assembler for testing,<br>
but given we started with that -- let's just stick to it.</blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br>
> Added:<br>
>     lld/trunk/test/elf2/relocations.test<br>
> Modified:<br>
>     lld/trunk/ELF/Writer.cpp<br>
><br>
> Modified: lld/trunk/ELF/Writer.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=246902&r1=246901&r2=246902&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=246902&r1=246901&r2=246902&view=diff</a><br>
> ==============================================================================<br>
> --- lld/trunk/ELF/Writer.cpp (original)<br>
> +++ lld/trunk/ELF/Writer.cpp Fri Sep  4 19:36:03 2015<br>
> @@ -271,8 +271,12 @@ template <class ELFT> void OutputSection<br>
>                                       SymVA + (RI.r_addend - (P + Offset)));<br>
>            break;<br>
>          case llvm::ELF::R_X86_64_32:<br>
> +        case llvm::ELF::R_X86_64_32S:<br>
>            support::endian::write32le(Location, SymVA + RI.r_addend);<br>
>            break;<br>
<br>
</span>Shouldn't we take care of sign extension somehow?<br>
<span class=""><font color="#888888"><br>
--<br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<br>
</font></span><div class=""><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>