<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoPlainText>Ping?<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>-----Original Message-----<br>From: Betul Buyukkurt [mailto:betulb@codeaurora.org] <br>Sent: Thursday, September 03, 2015 12:39 PM<br>To: betulb@codeaurora.org; mail@justinbogner.com; dnovillo@google.com; dsule@codeaurora.org; davidxl@google.com; ibaev@codeaurora.org<br>Cc: llvm-commits@lists.llvm.org<br>Subject: Re: [PATCH] D10674: Value profiling - patchset 3</p><p class=MsoPlainText> </p><p class=MsoPlainText>betulb updated this revision to Diff 33963.<o:p></o:p></p><p class=MsoPlainText>betulb added a comment.<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>In this revision:<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>- Turned the error to assert for "hash value not matching any known key"<o:p></o:p></p><p class=MsoPlainText>- Used rvalue-reference semantics when passing arguments into the InstrProfWriter's addRecord routine. String table usage caused the undesirable removal of const qualifier from addRecord's argument. Now the arguments to addRecord are clearly passed using std::move()<o:p></o:p></p><p class=MsoPlainText>- In combineInstrProfRecords, tried to account for when value profiling is not enabled for a given kind for Source vs enabled for Dest and vice versa.<o:p></o:p></p><p class=MsoPlainText>- Used std::vector's empty() instead of comparing size() against 0<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText><a href="http://reviews.llvm.org/D10674"><span style='color:windowtext;text-decoration:none'>http://reviews.llvm.org/D10674</span></a><o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p><p class=MsoPlainText>Files:<o:p></o:p></p><p class=MsoPlainText> include/llvm/ProfileData/InstrProf.h<o:p></o:p></p><p class=MsoPlainText> include/llvm/ProfileData/InstrProfReader.h<o:p></o:p></p><p class=MsoPlainText> include/llvm/ProfileData/InstrProfWriter.h<o:p></o:p></p><p class=MsoPlainText> lib/ProfileData/InstrProf.cpp<o:p></o:p></p><p class=MsoPlainText> lib/ProfileData/InstrProfIndexed.h<o:p></o:p></p><p class=MsoPlainText> lib/ProfileData/InstrProfReader.cpp<o:p></o:p></p><p class=MsoPlainText> lib/ProfileData/InstrProfWriter.cpp<o:p></o:p></p><p class=MsoPlainText> tools/llvm-profdata/llvm-profdata.cpp<o:p></o:p></p><p class=MsoPlainText> unittests/ProfileData/CoverageMappingTest.cpp<o:p></o:p></p><p class=MsoPlainText> unittests/ProfileData/InstrProfTest.cpp<o:p></o:p></p><p class=MsoPlainText><o:p> </o:p></p></div></body></html>