<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 09/02/2015 03:00 PM, David Blaikie
wrote:<br>
</div>
<blockquote
cite="mid:CAENS6EvVOJzHR7qVDSaMe40+0hoV2-zdAYSuVjQ7M6FysrnHSQ@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Sep 2, 2015 at 2:57 PM,
Philip Reames via llvm-commits <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org"
target="_blank">llvm-commits@lists.llvm.org</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Author:
reames<br>
Date: Wed Sep 2 16:57:17 2015<br>
New Revision: 246717<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=246717&view=rev"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246717&view=rev</a><br>
Log:<br>
Fix release build warning for unused function<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp<br>
<br>
Modified:
llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp?rev=246717&r1=246716&r2=246717&view=diff"
rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp?rev=246717&r1=246716&r2=246717&view=diff</a><br>
==============================================================================<br>
---
llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
(original)<br>
+++
llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
Wed Sep 2 16:57:17 2015<br>
@@ -616,11 +616,12 @@ private:<br>
Value *base; // non null only if status == base<br>
};<br>
<br>
+#ifndef NDEBUG<br>
inline raw_ostream &operator<<(raw_ostream
&OS, const BDVState &State) {<br>
</blockquote>
<div><br>
I assume this function is within an anonymous namespace?
(otherwise -Wunused-function wouldn't fire on it) - it's
LLVM style to use "static" for file-local functions (and
only to use anonymous namespaces to wrap types, not
functions).<br>
</div>
</div>
</div>
</div>
</blockquote>
You are correct. It's right between two class definitions. I
hadn't noticed that it was within a namespace. I'll fix that in a
moment.<br>
<blockquote
cite="mid:CAENS6EvVOJzHR7qVDSaMe40+0hoV2-zdAYSuVjQ7M6FysrnHSQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
State.print(OS);<br>
return OS;<br>
}<br>
-<br>
+#endif<br>
<br>
typedef DenseMap<Value *, BDVState>
ConflictStateMapTy;<br>
// Values of type BDVState form a lattice, and this is a
helper<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a moz-do-not-send="true"
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>