<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Sep 1, 2015, at 3:48 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com" class="">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Isn't it a little bit of a misnomer to continue to call it 'getSuccessorV', etc.? IMO, something like getSuccessorImpl would be more fitting.</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Sep 1, 2015 at 3:41 PM, Pete Cooper via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Duncan, David<br class="">
<br class="">
I took a break from devirtualizing Value as David raised performance concerns I wanted to check before continuing.<br class="">
<br class="">
The original series of patches and discussion were around here: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_pipermail_llvm-2Dcommits_Week-2Dof-2DMon-2D20150622_282810.html&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BerEYhiaI1GmCI3aHR4i5-TzETn6EKLF00_njq3c5KA&s=ZsfrT-MHZJfbR_OMkIT0H57JCJDsgZOt-aPLkTpzri4&e=" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150622/282810.html</a><br class="">
<br class="">
This is what was patch 0005 in that series, but updated now that we have additional TerminatorInst’s since then.<br class="">
<br class="">
I ran our performance suite here and there were no regressions. It actually slightly improved (about 2-3%) MultiSource/Benchmarks/TSVC/ControlLoops-dbl/ControlLoops-dbl.<br class="">
<br class="">
Assuming this patch lands ok, i’ll continue with the same testing methodology for the remainder of the series.<br class="">
<br class="">
Cheers,<br class="">
Pete<br class="">
<br class="">
<br class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BerEYhiaI1GmCI3aHR4i5-TzETn6EKLF00_njq3c5KA&s=EGd8eoHXQo7uNGXzUN8vZJ3UK9To1OOz9nrm7uYCE9c&e=" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></body></html>