<div dir="ltr">Isn't it a little bit of a misnomer to continue to call it 'getSuccessorV', etc.?  IMO, something like getSuccessorImpl would be more fitting.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 1, 2015 at 3:41 PM, Pete Cooper via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Duncan, David<br>
<br>
I took a break from devirtualizing Value as David raised performance concerns I wanted to check before continuing.<br>
<br>
The original series of patches and discussion were around here: <a href="http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150622/282810.html" rel="noreferrer" target="_blank">http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150622/282810.html</a><br>
<br>
This is what was patch 0005 in that series, but updated now that we have additional TerminatorInst’s since then.<br>
<br>
I ran our performance suite here and there were no regressions.  It actually slightly improved (about 2-3%) MultiSource/Benchmarks/TSVC/ControlLoops-dbl/ControlLoops-dbl.<br>
<br>
Assuming this patch lands ok, i’ll continue with the same testing methodology for the remainder of the series.<br>
<br>
Cheers,<br>
Pete<br>
<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>