<div dir="ltr">Regarding the failure log, neither lit nor python would be culprit, I guess.<div>I supposed r245946 tried to resolve indirection issues. </div><div><br><div>We'd need to implement "retry" for win32.</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 1, 2015 at 2:15 PM Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Right, <span style="font-size:12.8000001907349px">r245946 was an attempt to fix the problem in asan tests, but it didn't seem to work.</span></div><div><br></div>Given that it didn't work and it uses private details of subprocess.Popen, I'd rather take it back out and try to understand the real cause of the problem.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 31, 2015 at 5:49 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>The failure in asan is nothing to do with r245946, I guess.</div><div>I think r245946 was reasonable (better than nothing).<div><div><br><br><span style="font-size:13.1999998092651px;line-height:19.7999992370605px"><br></span><div class="gmail_quote"><div dir="ltr">On Tue, Sep 1, 2015 at 6:43 AM Reid Kleckner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Mon Aug 31 16:42:02 2015<br>
New Revision: 246491<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246491&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246491&view=rev</a><br>
Log:<br>
Revert "[lit] Speculatively fix PR24554 by manually closing the process handle"<br>
<br>
This reverts commit r245946. It didn't help the problem:<br>
<a href="http://lab.llvm.org:8011/builders/sanitizer-windows/builds/9179/steps/run%20tests/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/builders/sanitizer-windows/builds/9179/steps/run%20tests/logs/stdio</a><br>
LINK : fatal error LNK1104: cannot open file<br>
<br>
Modified:<br>
llvm/trunk/utils/lit/lit/TestRunner.py<br>
<br>
Modified: llvm/trunk/utils/lit/lit/TestRunner.py<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=246491&r1=246490&r2=246491&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=246491&r1=246490&r2=246491&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)<br>
+++ llvm/trunk/utils/lit/lit/TestRunner.py Mon Aug 31 16:42:02 2015<br>
@@ -257,9 +257,6 @@ def executeShCmd(cmd, shenv, results):<br>
exitCode = None<br>
for i,(out,err) in enumerate(procData):<br>
res = procs[i].wait()<br>
- # On Windows, manually close the process handles.<br>
- if kIsWindows:<br>
- procs[i]._handle.Close()<br>
# Detect Ctrl-C in subprocess.<br>
if res == -signal.SIGINT:<br>
raise KeyboardInterrupt<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div></div></div>
</blockquote></div><br></div>
</blockquote></div>