<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Aug 31, 2015, at 3:04 PM, Quentin Colombet via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi Nick,<br class=""><br class="">I was looking into why this patch was introducing other problems and I think it boils down to I’ve screwed up my rebase of this patch.<br class="">Doing it again from scratch (after reverting my revert r245394) seems to yield correct code.<br class=""><br class="">I am going to push your changes.<br class=""><br class="">I let you know which revision it is so that you can double check that I did not screw up again!<br class=""></div></blockquote><div><br class=""></div><div>This landed in <span style="font-family: Menlo; font-size: 11px;" class="">Committed revision 246502.</span></div><div><br class=""></div>Q.<br class=""><blockquote type="cite" class=""><div class=""><br class="">Thanks,<br class="">-Quentin<br class=""><br class=""><br class=""><blockquote type="cite" class="">On Aug 19, 2015, at 2:12 PM, Nicholas White <<a href="mailto:n.j.white@gmail.com" class="">n.j.white@gmail.com</a>> wrote:<br class=""><br class="">Hi - sorry I haven't had time to address Hal's review comments yet,<br class="">and thanks for the additional test case Quentin. This patch (or as you<br class="">pointed out, series of edits to the sext / zext code) is only intended<br class="">to fix outstanding bugs, not add any new functionality. It'd be good<br class="">if this gets into 3.7 but the bugs it fixes are in the 3.6 release and<br class="">aren't causing too much pain - and touching this part of the codebase<br class="">has a lot of downstream consequences. Thanks -<br class=""><br class="">Nick<br class=""></blockquote><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></body></html>