<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Aug 30, 2015 at 12:51 PM, Tobias Grosser via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: grosser<br>
Date: Sun Aug 30 14:51:01 2015<br>
New Revision: 246396<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=246396&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=246396&view=rev</a><br>
Log:<br>
Do not store into a temporary twine<br>
<br>
For some reason, this causes memory corruption issues. Let's just avoid it.<br></blockquote><div><br>Twines are not designed to be named, as such.<br><br>A Twine expresion stores references to Twine subexpressions that are local to the C++ full expression - once you are outside that full expression those references are dangling (as the subexpression Twines are out of scope).<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
<br>
Modified: polly/trunk/lib/CodeGen/BlockGenerators.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=246396&r1=246395&r2=246396&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/polly/trunk/lib/CodeGen/BlockGenerators.cpp?rev=246396&r1=246395&r2=246396&view=diff</a><br>
==============================================================================<br>
--- polly/trunk/lib/CodeGen/BlockGenerators.cpp (original)<br>
+++ polly/trunk/lib/CodeGen/BlockGenerators.cpp Sun Aug 30 14:51:01 2015<br>
@@ -401,8 +401,8 @@ void BlockGenerator::generateScalarLoads<br>
       continue;<br>
<br>
     auto *Address = getOrCreateAlloca(MA);<br>
-    auto Name = Address->getName() + ".reload";<br>
-    BBMap[MA.getBaseAddr()] = Builder.CreateLoad(Address, Name);<br>
+    BBMap[MA.getBaseAddr()] =<br>
+        Builder.CreateLoad(Address, Address->getName() + ".reload");<br>
   }<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>