It would be my preferred approach, yes. <br><div class="gmail_quote"><div dir="ltr">On Mon, 24 Aug 2015 at 14:50, <a href="mailto:silviu.baranga@arm.com">silviu.baranga@arm.com</a> via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">sbaranga added inline comments.<br>
<br>
================<br>
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:2187<br>
@@ -2186,1 +2186,3 @@<br>
   }<br>
+  case Intrinsic::aarch64_neon_smax:<br>
+  case Intrinsic::aarch64_neon_umax:<br>
----------------<br>
jmolloy wrote:<br>
> I don't really like having the switch inside the switch - each case is just one line anyway, I think we're removing readability.<br>
In that case would removing this switch and having a<br>
<br>
return DAG.getNode(ISD::SMIN, dl, Op.getValueType(), ...)<br>
<br>
for each min/max case in the original switch be better here?<br>
<br>
<br>
<a href="http://reviews.llvm.org/D12276" rel="noreferrer" target="_blank">http://reviews.llvm.org/D12276</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>